Naphtali Sprei
0859df68df
Fix for commit 3f9cb1c14dc368f41447db5f78d6248c4f100ad4
...
Here's a patch to fix the issue introduced by me, as Reimar Döffinger pointed out,
Reimar Döffinger wrote:
> On Thu, Aug 13, 2009 at 03:01:20PM +0300, Naphtali Sprei wrote:
>> Bug fix for segfault when run as i82551 HW:
>> Use Extended TBD only when HW supports it (i82558 and up).
>>
>> Added assertions to guard from such buffer overflow
>> Introduce the MAX_TCB_BYTE_COUNT macro
>> Allocate buf big enough as HW needs (MAX_ETH_FRAME_SIZE -> MAX_TCB_BYTE_COUNT)
>>
>>
>> I don't feel 100% OK with the "s->device >= i82558B" condition
>> since it relies on the numeric (hex) value of those defines, which currently
>> is correct, but changes (which I don't forsee now) might break it.
>
> It seems this was applied. Unfortunately this breaks things on FreeBSD.
> There seem to be multiple issues.
> First, the intel document says the 82551, 82550, 82559 models are all
> supersets of the 82558. Or in other words: they all support this
> feature.
> Only the 82557 does not.
> But then even for that the FreeBSD driver will fail.
> The reason for that is this line:
> eeprom_contents[0xa] = 0x4000;
> the value here must be 0x01000 for all 82557 models it seems.
Correct the logic of determining devices that supports
extended TxCB: only the 82557 do not support it.
Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2009-09-09 14:57:21 -05:00
..
2009-09-04 09:37:34 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:30:22 -05:00
2009-06-29 14:18:08 -05:00
2009-06-20 05:13:29 +04:00
2009-08-27 20:43:28 -05:00
2009-07-16 20:47:01 +00:00
2009-09-04 09:37:23 -05:00
2009-08-27 20:35:30 -05:00
2009-06-29 14:18:08 -05:00
2009-08-25 18:29:31 +00:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-25 18:29:31 +00:00
2009-06-13 19:17:11 -05:00
2009-08-27 20:43:28 -05:00
2009-07-27 14:09:21 -05:00
2009-07-16 20:47:01 +00:00
2009-07-27 08:39:28 -05:00
2009-07-16 20:47:01 +00:00
2009-07-27 14:09:21 -05:00
2009-09-09 14:55:17 -05:00
2009-07-16 20:47:01 +00:00
2009-07-16 20:47:01 +00:00
2009-07-16 20:47:01 +00:00
2009-07-16 20:47:01 +00:00
2009-07-16 20:47:01 +00:00
2009-09-09 14:55:16 -05:00
2009-08-27 20:43:28 -05:00
2009-08-28 14:34:27 +04:00
2009-08-25 18:29:31 +00:00
2009-07-27 14:08:23 -05:00
2009-06-29 14:18:08 -05:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-07-16 20:47:01 +00:00
2009-08-27 20:47:01 -05:00
2009-08-29 16:36:58 +03:00
2009-09-09 14:57:21 -05:00
2009-07-16 20:47:01 +00:00
2009-07-16 20:47:01 +00:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-09-09 14:57:19 -05:00
2009-08-25 18:29:31 +00:00
2009-06-15 21:00:50 +02:00
2009-08-25 18:29:31 +00:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-07-27 14:08:23 -05:00
2009-06-15 21:00:50 +02:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:30:11 -05:00
2009-07-16 20:47:01 +00:00
2009-08-25 18:29:31 +00:00
2009-07-27 14:09:14 -05:00
2009-08-25 18:29:31 +00:00
2009-09-04 09:37:23 -05:00
2009-09-04 09:37:23 -05:00
2009-07-27 14:08:23 -05:00
2009-07-27 14:09:21 -05:00
2009-08-25 18:29:31 +00:00
2009-07-27 14:08:23 -05:00
2009-08-25 18:29:31 +00:00
2009-08-31 19:30:15 +00:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:30:21 -05:00
2009-08-24 08:01:42 -05:00
2009-09-04 09:37:34 -05:00
2009-08-27 20:43:28 -05:00
2009-08-25 18:29:31 +00:00
2009-08-28 20:46:21 +00:00
2009-08-25 18:29:31 +00:00
2009-08-28 19:12:16 +00:00
2009-08-27 20:43:28 -05:00
2009-08-25 18:29:31 +00:00
2009-08-27 20:43:28 -05:00
2009-09-09 14:57:19 -05:00
2009-08-27 20:43:28 -05:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-06-16 15:18:38 -05:00
2009-07-27 14:08:23 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-27 20:30:11 -05:00
2009-09-04 09:37:34 -05:00
2009-06-29 14:18:08 -05:00
2009-09-04 09:37:27 -05:00
2009-07-09 16:58:07 -05:00
2009-08-27 20:43:28 -05:00
2009-08-25 18:29:31 +00:00
2009-06-24 09:09:14 -05:00
2009-08-25 18:29:31 +00:00
2009-08-27 20:43:28 -05:00
2009-07-27 14:08:23 -05:00
2009-08-27 20:47:00 -05:00
2009-07-16 20:47:01 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-07-16 20:47:01 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-07-27 14:09:21 -05:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-09-06 16:31:58 +00:00
2009-09-04 09:37:24 -05:00
2009-07-27 14:08:13 -05:00
2009-08-27 20:30:22 -05:00
2009-09-09 14:57:19 -05:00
2009-09-04 09:37:23 -05:00
2009-09-09 14:57:21 -05:00
2009-08-27 20:43:28 -05:00
2009-09-04 09:37:27 -05:00
2009-08-27 20:47:00 -05:00
2009-07-27 14:09:19 -05:00
2009-08-27 20:35:30 -05:00
2009-08-27 20:35:30 -05:00
2009-09-04 09:37:34 -05:00
2009-09-04 09:37:26 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-07-27 14:09:21 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-16 11:13:18 +00:00
2009-09-04 09:37:23 -05:00
2009-08-15 14:27:05 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-15 14:27:05 +00:00
2009-08-10 13:05:28 -05:00
2009-08-15 14:27:05 +00:00
2009-06-17 15:49:37 +00:00
2009-08-27 20:43:33 -05:00
2009-09-09 14:55:18 -05:00
2009-09-09 14:55:18 -05:00
2009-09-09 14:55:18 -05:00
2009-08-16 11:13:18 +00:00
2009-08-25 18:29:31 +00:00
2009-08-10 13:05:28 -05:00
2009-09-04 09:37:23 -05:00
2009-09-04 09:37:23 -05:00
2009-08-27 20:30:22 -05:00
2009-08-31 19:30:15 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-07-27 14:09:21 -05:00
2009-08-25 18:29:31 +00:00
2009-08-27 20:43:28 -05:00
2009-07-16 17:28:51 -05:00
2009-08-10 13:05:48 -05:00
2009-08-28 19:12:16 +00:00
2009-09-09 14:57:20 -05:00
2009-09-09 14:57:20 -05:00
2009-09-04 09:37:27 -05:00
2009-08-25 18:29:31 +00:00
2009-08-27 20:43:28 -05:00
2009-09-09 14:55:18 -05:00
2009-09-09 14:57:20 -05:00
2009-08-28 14:34:29 +04:00
2009-08-27 20:43:28 -05:00
2009-09-09 14:57:19 -05:00
2009-09-09 14:57:19 -05:00
2009-09-09 14:57:19 -05:00
2009-09-09 14:57:19 -05:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-09-04 09:37:23 -05:00
2009-08-25 18:29:31 +00:00
2009-08-25 18:29:31 +00:00
2009-08-27 20:43:33 -05:00
2009-08-28 20:22:52 +00:00
2009-08-29 16:37:09 +03:00
2009-08-31 19:30:18 +00:00
2009-08-25 18:29:31 +00:00
2009-08-10 13:05:48 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-07-16 20:47:01 +00:00
2009-07-16 20:47:01 +00:00
2009-08-28 20:46:15 +00:00
2009-08-08 21:43:12 +00:00
2009-09-04 09:37:27 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-31 19:30:21 +00:00
2009-08-27 20:43:28 -05:00
2009-08-23 12:23:30 +00:00
2009-09-06 16:34:18 +00:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-07-16 17:28:51 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-07-16 20:47:01 +00:00
2009-08-25 18:29:31 +00:00
2009-09-09 14:57:20 -05:00
2009-08-27 20:43:28 -05:00
2009-09-04 09:37:27 -05:00
2009-07-16 20:47:01 +00:00
2009-07-16 20:47:01 +00:00
2009-08-25 18:29:31 +00:00
2009-08-27 20:43:28 -05:00
2009-09-04 09:37:23 -05:00
2009-09-09 14:55:17 -05:00
2009-09-09 14:55:17 -05:00
2009-09-09 14:55:18 -05:00
2009-09-09 14:55:17 -05:00
2009-09-09 14:57:19 -05:00
2009-09-09 14:55:17 -05:00
2009-09-09 14:55:17 -05:00
2009-09-09 14:55:18 -05:00
2009-09-09 14:55:17 -05:00
2009-09-09 14:55:18 -05:00
2009-09-09 14:55:18 -05:00
2009-09-09 14:55:17 -05:00
2009-09-09 14:55:17 -05:00
2009-09-04 09:37:23 -05:00
2009-09-09 14:55:18 -05:00
2009-09-09 14:55:13 -05:00
2009-09-09 14:55:14 -05:00
2009-09-09 14:55:11 -05:00
2009-09-09 14:55:11 -05:00
2009-09-09 14:55:11 -05:00
2009-09-09 14:55:14 -05:00
2009-08-27 20:30:23 -05:00
2009-06-24 09:09:15 -05:00
2009-08-27 20:30:22 -05:00
2009-07-22 10:58:49 -05:00
2009-08-27 20:43:33 -05:00
2009-07-09 16:58:08 -05:00
2009-08-10 13:05:28 -05:00
2009-09-09 14:55:11 -05:00
2009-08-27 20:35:24 -05:00
2009-08-27 20:35:24 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-07-16 20:47:01 +00:00
2009-07-16 20:47:01 +00:00
2009-07-27 14:08:23 -05:00
2009-07-27 14:08:23 -05:00
2009-07-16 20:47:01 +00:00
2009-07-16 20:47:01 +00:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-08-27 20:43:28 -05:00
2009-07-16 17:28:51 -05:00
2009-08-25 18:29:31 +00:00