qemu/target-i386
Markus Armbruster 65cd9064e1 qom: Clean up fragile use of error_is_set() in set() methods
Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque.  It's wrong when ERRP
may be null, because errors go undetected when it is.  It's fragile
when proving ERRP non-null involves a non-local argument.  Else, it's
unnecessarily opaque (see commit 84d18f0).

I guess the error_is_set(errp) in the ObjectProperty set() methods are
merely fragile right now, because I can't find a call chain that
passes a null errp argument.

Make the code more robust and more obviously correct: receive the
error in a local variable, then propagate it through the parameter.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
2014-05-05 19:08:49 +02:00
..
arch_dump.c
arch_memory_mapping.c
cc_helper_template.h
cc_helper.c
cpu-qom.h
cpu.c qom: Clean up fragile use of error_is_set() in set() methods 2014-05-05 19:08:49 +02:00
cpu.h
excp_helper.c
fpu_helper.c
gdbstub.c
helper.c
helper.h
int_helper.c
ioport-user.c
kvm_i386.h
kvm-stub.c
kvm.c
machine.c target-i386: reorder fields in cpu/msr_hyperv_hypercall subsection 2014-04-05 10:49:05 +01:00
Makefile.objs
mem_helper.c
misc_helper.c
ops_sse_header.h
ops_sse.h
seg_helper.c
shift_helper_template.h
smm_helper.c
svm_helper.c
svm.h
TODO
topology.h
translate.c