5325cc34a2
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
85 lines
2.5 KiB
C
85 lines
2.5 KiB
C
/*
|
|
* BBC micro:bit machine
|
|
* http://tech.microbit.org/hardware/
|
|
*
|
|
* Copyright 2018 Joel Stanley <joel@jms.id.au>
|
|
*
|
|
* This code is licensed under the GPL version 2 or later. See
|
|
* the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "hw/boards.h"
|
|
#include "hw/arm/boot.h"
|
|
#include "sysemu/sysemu.h"
|
|
#include "exec/address-spaces.h"
|
|
|
|
#include "hw/arm/nrf51_soc.h"
|
|
#include "hw/i2c/microbit_i2c.h"
|
|
#include "hw/qdev-properties.h"
|
|
|
|
typedef struct {
|
|
MachineState parent;
|
|
|
|
NRF51State nrf51;
|
|
MicrobitI2CState i2c;
|
|
} MicrobitMachineState;
|
|
|
|
#define TYPE_MICROBIT_MACHINE MACHINE_TYPE_NAME("microbit")
|
|
|
|
#define MICROBIT_MACHINE(obj) \
|
|
OBJECT_CHECK(MicrobitMachineState, obj, TYPE_MICROBIT_MACHINE)
|
|
|
|
static void microbit_init(MachineState *machine)
|
|
{
|
|
MicrobitMachineState *s = MICROBIT_MACHINE(machine);
|
|
MemoryRegion *system_memory = get_system_memory();
|
|
MemoryRegion *mr;
|
|
|
|
object_initialize_child(OBJECT(machine), "nrf51", &s->nrf51,
|
|
TYPE_NRF51_SOC);
|
|
qdev_prop_set_chr(DEVICE(&s->nrf51), "serial0", serial_hd(0));
|
|
object_property_set_link(OBJECT(&s->nrf51), "memory",
|
|
OBJECT(system_memory), &error_fatal);
|
|
sysbus_realize(SYS_BUS_DEVICE(&s->nrf51), &error_fatal);
|
|
|
|
/*
|
|
* Overlap the TWI stub device into the SoC. This is a microbit-specific
|
|
* hack until we implement the nRF51 TWI controller properly and the
|
|
* magnetometer/accelerometer devices.
|
|
*/
|
|
object_initialize_child(OBJECT(machine), "microbit.twi", &s->i2c,
|
|
TYPE_MICROBIT_I2C);
|
|
sysbus_realize(SYS_BUS_DEVICE(&s->i2c), &error_fatal);
|
|
mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->i2c), 0);
|
|
memory_region_add_subregion_overlap(&s->nrf51.container, NRF51_TWI_BASE,
|
|
mr, -1);
|
|
|
|
armv7m_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename,
|
|
s->nrf51.flash_size);
|
|
}
|
|
|
|
static void microbit_machine_class_init(ObjectClass *oc, void *data)
|
|
{
|
|
MachineClass *mc = MACHINE_CLASS(oc);
|
|
|
|
mc->desc = "BBC micro:bit";
|
|
mc->init = microbit_init;
|
|
mc->max_cpus = 1;
|
|
}
|
|
|
|
static const TypeInfo microbit_info = {
|
|
.name = TYPE_MICROBIT_MACHINE,
|
|
.parent = TYPE_MACHINE,
|
|
.instance_size = sizeof(MicrobitMachineState),
|
|
.class_init = microbit_machine_class_init,
|
|
};
|
|
|
|
static void microbit_machine_init(void)
|
|
{
|
|
type_register_static(µbit_info);
|
|
}
|
|
|
|
type_init(microbit_machine_init);
|