8aade934df
ops is assigned again just below, and the result of the assignment must
be non-NULL.
Originally, the check for NULL was meant to be a check for the existence
of the ops class:
ops = ACCEL_OPS_CLASS(object_class_by_name(ops_name));
...
g_assert(ops != NULL);
(where the ops assignment begot the one that I am removing); but this is
meaningless now that oc is checked to be non-NULL before ops is assigned
(commit 5141e9a23f, "accel: abort if we fail to load the accelerator
plugin", 2022-11-06).
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
105 lines
3.1 KiB
C
105 lines
3.1 KiB
C
/*
|
|
* QEMU accel class, system emulation components
|
|
*
|
|
* Copyright (c) 2003-2008 Fabrice Bellard
|
|
* Copyright (c) 2014 Red Hat Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/accel.h"
|
|
#include "hw/boards.h"
|
|
#include "sysemu/cpus.h"
|
|
#include "qemu/error-report.h"
|
|
#include "accel-system.h"
|
|
|
|
int accel_init_machine(AccelState *accel, MachineState *ms)
|
|
{
|
|
AccelClass *acc = ACCEL_GET_CLASS(accel);
|
|
int ret;
|
|
ms->accelerator = accel;
|
|
*(acc->allowed) = true;
|
|
ret = acc->init_machine(ms);
|
|
if (ret < 0) {
|
|
ms->accelerator = NULL;
|
|
*(acc->allowed) = false;
|
|
object_unref(OBJECT(accel));
|
|
} else {
|
|
object_set_accelerator_compat_props(acc->compat_props);
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
AccelState *current_accel(void)
|
|
{
|
|
return current_machine->accelerator;
|
|
}
|
|
|
|
void accel_setup_post(MachineState *ms)
|
|
{
|
|
AccelState *accel = ms->accelerator;
|
|
AccelClass *acc = ACCEL_GET_CLASS(accel);
|
|
if (acc->setup_post) {
|
|
acc->setup_post(ms, accel);
|
|
}
|
|
}
|
|
|
|
/* initialize the arch-independent accel operation interfaces */
|
|
void accel_system_init_ops_interfaces(AccelClass *ac)
|
|
{
|
|
const char *ac_name;
|
|
char *ops_name;
|
|
ObjectClass *oc;
|
|
AccelOpsClass *ops;
|
|
|
|
ac_name = object_class_get_name(OBJECT_CLASS(ac));
|
|
g_assert(ac_name != NULL);
|
|
|
|
ops_name = g_strdup_printf("%s" ACCEL_OPS_SUFFIX, ac_name);
|
|
oc = module_object_class_by_name(ops_name);
|
|
if (!oc) {
|
|
error_report("fatal: could not load module for type '%s'", ops_name);
|
|
exit(1);
|
|
}
|
|
g_free(ops_name);
|
|
/*
|
|
* all accelerators need to define ops, providing at least a mandatory
|
|
* non-NULL create_vcpu_thread operation.
|
|
*/
|
|
ops = ACCEL_OPS_CLASS(oc);
|
|
if (ops->ops_init) {
|
|
ops->ops_init(ops);
|
|
}
|
|
cpus_register_accel(ops);
|
|
}
|
|
|
|
static const TypeInfo accel_ops_type_info = {
|
|
.name = TYPE_ACCEL_OPS,
|
|
.parent = TYPE_OBJECT,
|
|
.abstract = true,
|
|
.class_size = sizeof(AccelOpsClass),
|
|
};
|
|
|
|
static void accel_system_register_types(void)
|
|
{
|
|
type_register_static(&accel_ops_type_info);
|
|
}
|
|
type_init(accel_system_register_types);
|