From ff5bbe56c6f9a74c2d77389a21d5d2368458c939 Mon Sep 17 00:00:00 2001 From: Edgar Kaziahmedov Date: Mon, 20 Mar 2017 12:27:02 +0300 Subject: [PATCH] parallels: fix default options parsing parallels block driver is completely broken since commit commit 75cdcd1553e74b5edc58aed23e3b2da8dabb1876 Author: Markus Armbruster Date: Tue Feb 21 21:14:08 2017 +0100 option: Fix checking of sizes for overflow and trailing crap Right now even simple qemu-io -c "read 512 64k" 1.hds ends up with Unexpected error in parse_option_size() at util/qemu-option.c:188: Parameter 'prealloc-size' expects a non-negative number below 2^64 Aborted (core dumped) The cure is simple - we should use 'M' as a suffix in default option value instead of 'MiB'. Signed-off-by: Edgar Kaziahmedov Signed-off-by: Denis V. Lunev Message-id: 1490002022-22653-1-git-send-email-den@openvz.org CC: Markus Armbruster CC: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi --- block/parallels.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/parallels.c b/block/parallels.c index 19935e29a9..6bf93753e8 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -114,7 +114,7 @@ static QemuOptsList parallels_runtime_opts = { .name = PARALLELS_OPT_PREALLOC_SIZE, .type = QEMU_OPT_SIZE, .help = "Preallocation size on image expansion", - .def_value_str = "128MiB", + .def_value_str = "128M", }, { .name = PARALLELS_OPT_PREALLOC_MODE,