mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qed: don't pass NULL to memcpy

Browse Source 
Spotted by Clang Analyzer

[Note this memcpy call has always been safe because the length will be 0
when the pointer is NULL]

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
This commit is contained in:
Pavel Borzenkov 2011-10-18 21:17:35 +04:00 committed by Stefan Hajnoczi
parent 8379e46d1f
commit feba23b143
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
block/qed.c
View File

@ -1425,8 +1425,10 @@ static int bdrv_qed_change_backing_file(BlockDriverState *bs,
memcpy(buffer, &le_header, sizeof(le_header)); memcpy(buffer, &le_header, sizeof(le_header));
buffer_len = sizeof(le_header); buffer_len = sizeof(le_header);
if (backing_file) {
memcpy(buffer + buffer_len, backing_file, backing_file_len); memcpy(buffer + buffer_len, backing_file, backing_file_len);
buffer_len += backing_file_len; buffer_len += backing_file_len;
}
/* Write new header */ /* Write new header */
ret = bdrv_pwrite_sync(bs->file, 0, buffer, buffer_len); ret = bdrv_pwrite_sync(bs->file, 0, buffer, buffer_len);