job: Add job_delete()

This moves freeing the Job object and its fields from block_job_unref()
to job_delete().

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
This commit is contained in:
Kevin Wolf 2018-04-12 19:06:53 +02:00
parent 252291eaea
commit fd61a701f1
3 changed files with 10 additions and 2 deletions

View File

@ -261,9 +261,8 @@ void block_job_unref(BlockJob *job)
block_job_detach_aio_context, job);
blk_unref(job->blk);
error_free(job->blocker);
g_free(job->job.id);
assert(!timer_pending(&job->sleep_timer));
g_free(job);
job_delete(&job->job);
}
}

View File

@ -62,6 +62,9 @@ struct JobDriver {
*/
void *job_create(const char *job_id, const JobDriver *driver, Error **errp);
/** Frees the @job object. */
void job_delete(Job *job);
/** Returns the JobType of a given Job. */
JobType job_type(const Job *job);

6
job.c
View File

@ -56,3 +56,9 @@ void *job_create(const char *job_id, const JobDriver *driver, Error **errp)
return job;
}
void job_delete(Job *job)
{
g_free(job->id);
g_free(job);
}