mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

object: do not free class properties

Browse Source 
The release callback is called during object_property_del_all(), on a
live instance. But class properties are common among all
instances. It is not currently called, because we don't release
classes, but it would not be correct if we did.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200110153039.1379601-12-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Marc-André Lureau 2020-01-10 19:30:24 +04:00 committed by Paolo Bonzini
parent 0e76ed0a5d
commit fc4fe712ae
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qom/object.c
View File

@ -2127,7 +2127,7 @@ object_class_property_add_str(ObjectClass *klass, const char *name,
rv = object_class_property_add(klass, name, "string",
get ? property_get_str : NULL,
set ? property_set_str : NULL,
property_release_str,
NULL,
prop, &local_err);
if (local_err) {
error_propagate(errp, local_err);
@ -2220,7 +2220,7 @@ object_class_property_add_bool(ObjectClass *klass, const char *name,
rv = object_class_property_add(klass, name, "bool",
get ? property_get_bool : NULL,
set ? property_set_bool : NULL,
property_release_bool,
NULL,
prop, &local_err);
if (local_err) {
error_propagate(errp, local_err);
@ -2312,7 +2312,7 @@ object_class_property_add_enum(ObjectClass *klass, const char *name,
rv = object_class_property_add(klass, name, typename,
get ? property_get_enum : NULL,
set ? property_set_enum : NULL,
property_release_enum,
NULL,
prop, &local_err);
if (local_err) {
error_propagate(errp, local_err);
@ -2413,7 +2413,7 @@ object_class_property_add_tm(ObjectClass *klass, const char *name,
rv = object_class_property_add(klass, name, "struct tm",
get ? property_get_tm : NULL, NULL,
property_release_tm,
NULL,
prop, &local_err);
if (local_err) {
error_propagate(errp, local_err);