mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel-iommu: don't warn guest errors when getting rid2pasid entry

Browse Source 
We use to warn on wrong rid2pasid entry. But this error could be
triggered by the guest and could happens during initialization. So
let's don't warn in this case.

Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20221028061436.30093-2-jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Yi Liu <yi.l.liu@intel.com>
This commit is contained in:
Jason Wang 2022-10-28 14:14:33 +08:00 committed by Michael S. Tsirkin
parent baa44bce87
commit fb1d084b44
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hw/i386/intel_iommu.c
View File

@ -1554,8 +1554,10 @@ static bool vtd_dev_pt_enabled(IntelIOMMUState *s, VTDContextEntry *ce)
if (s->root_scalable) { if (s->root_scalable) {
ret = vtd_ce_get_rid2pasid_entry(s, ce, &pe); ret = vtd_ce_get_rid2pasid_entry(s, ce, &pe);
if (ret) { if (ret) {
error_report_once("%s: vtd_ce_get_rid2pasid_entry error: %"PRId32, /*
__func__, ret); * This error is guest triggerable. We should assumt PT
* not enabled for safety.
*/
return false; return false;
} }
return (VTD_PE_GET_TYPE(&pe) == VTD_SM_PASID_ENTRY_PT); return (VTD_PE_GET_TYPE(&pe) == VTD_SM_PASID_ENTRY_PT);
@ -1569,14 +1571,12 @@ static bool vtd_as_pt_enabled(VTDAddressSpace *as)
{ {
IntelIOMMUState *s; IntelIOMMUState *s;
VTDContextEntry ce; VTDContextEntry ce;
int ret;
assert(as); assert(as);
s = as->iommu_state; s = as->iommu_state;
ret = vtd_dev_to_context_entry(s, pci_bus_num(as->bus), if (vtd_dev_to_context_entry(s, pci_bus_num(as->bus), as->devfn,
as->devfn, &ce); &ce)) {
if (ret) {
/* /*
* Possibly failed to parse the context entry for some reason * Possibly failed to parse the context entry for some reason
* (e.g., during init, or any guest configuration errors on * (e.g., during init, or any guest configuration errors on