mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/net/e1000e: Remove duplicated write handler for FLSWDATA register

Browse Source 
The FLSWDATA register writeop handler is initialized twice:

  3067 #define e1000e_putreg(x)    [x] = e1000e_mac_writereg
  3068 typedef void (*writeops)(E1000ECore *, int, uint32_t);
  3069 static const writeops e1000e_macreg_writeops[] = {
  ....
  3102     e1000e_putreg(FLSWDATA),
  ....
  3145     e1000e_putreg(FLSWDATA),

To avoid confusion, remove the duplicated initialization.

Fixes: 6f3fbe4ed0 ("net: Introduce e1000e device emulation")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20200904131402.590055-3-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Philippe Mathieu-Daudé 2020-09-04 15:14:02 +02:00 committed by Laurent Vivier
parent 4a4a604cc6
commit fb1953b22a
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hw/net/e1000e_core.c
View File

@ -3141,7 +3141,6 @@ static const writeops e1000e_macreg_writeops[] = {
e1000e_putreg(RXCFGL), e1000e_putreg(RXCFGL),
e1000e_putreg(TSYNCRXCTL), e1000e_putreg(TSYNCRXCTL),
e1000e_putreg(TSYNCTXCTL), e1000e_putreg(TSYNCTXCTL),
e1000e_putreg(FLSWDATA),
e1000e_putreg(EXTCNF_SIZE), e1000e_putreg(EXTCNF_SIZE),
e1000e_putreg(EEMNGCTL), e1000e_putreg(EEMNGCTL),
e1000e_putreg(RA), e1000e_putreg(RA),