hw/pci-host/raven.c: Mark raven_io_ops as implementing unaligned accesses
The raven_io_ops MemoryRegionOps is the only one in the source tree which sets .valid.unaligned to indicate that it should support unaligned accesses and which does not also set .impl.unaligned to indicate that its read and write functions can do the unaligned handling themselves. This is a problem, because at the moment the core memory system does not implement the support for handling unaligned accesses by doing a series of aligned accesses and combining them (system/memory.c:access_with_adjusted_size() has a TODO comment noting this). Fortunately raven_io_read() and raven_io_write() will correctly deal with the case of being passed an unaligned address, so we can fix the missing unaligned access support by setting .impl.unaligned in the MemoryRegionOps struct. Fixes: 9a1839164c9c8f06 ("raven: Implement non-contiguous I/O region") Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Tested-by: Cédric Le Goater <clg@redhat.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Message-id: 20240112134640.1775041-1-peter.maydell@linaro.org
This commit is contained in:
parent
855f94eca8
commit
f94d58f260
@ -200,6 +200,7 @@ static const MemoryRegionOps raven_io_ops = {
|
||||
.write = raven_io_write,
|
||||
.endianness = DEVICE_LITTLE_ENDIAN,
|
||||
.impl.max_access_size = 4,
|
||||
.impl.unaligned = true,
|
||||
.valid.unaligned = true,
|
||||
};
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user