mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

colo-compare: Remove superfluous NULL-pointer checks for s->iothread

Browse Source 
s->iothread is checked for NULL on object creation in colo_compare_complete,
so it's guaranteed not to be NULL.
This resolves a false alert from Coverity (CID 1429969).

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Lukas Straub 2020-07-31 07:06:04 +02:00 committed by Jason Wang
parent 5c1c3e4f02
commit f81cddfe8a
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
net/colo-compare.c
View File

@ -1442,9 +1442,7 @@ static void colo_compare_finalize(Object *obj)
qemu_chr_fe_deinit(&s->chr_notify_dev, false); qemu_chr_fe_deinit(&s->chr_notify_dev, false);
} }
if (s->iothread) { colo_compare_timer_del(s);
colo_compare_timer_del(s);
}
qemu_bh_delete(s->event_bh); qemu_bh_delete(s->event_bh);
@ -1470,9 +1468,7 @@ static void colo_compare_finalize(Object *obj)
g_hash_table_destroy(s->connection_track_table); g_hash_table_destroy(s->connection_track_table);
} }
if (s->iothread) { object_unref(OBJECT(s->iothread));
object_unref(OBJECT(s->iothread));
}
g_free(s->pri_indev); g_free(s->pri_indev);
g_free(s->sec_indev); g_free(s->sec_indev);