mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

accel/tcg: Use bool for page_find_alloc

Browse Source 
Bool is more appropriate type for the alloc parameter.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2022-08-10 15:27:46 -07:00
parent 6981f7026a
commit f79542afa7
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
accel/tcg/translate-all.c
View File

@ -465,7 +465,7 @@ void page_init(void)
#endif #endif
} }
static PageDesc *page_find_alloc(tb_page_addr_t index, int alloc) static PageDesc *page_find_alloc(tb_page_addr_t index, bool alloc)
{ {
PageDesc *pd; PageDesc *pd;
void **lp; void **lp;
@ -533,11 +533,11 @@ static PageDesc *page_find_alloc(tb_page_addr_t index, int alloc)
static inline PageDesc *page_find(tb_page_addr_t index) static inline PageDesc *page_find(tb_page_addr_t index)
{ {
return page_find_alloc(index, 0); return page_find_alloc(index, false);
} }
static void page_lock_pair(PageDesc **ret_p1, tb_page_addr_t phys1, static void page_lock_pair(PageDesc **ret_p1, tb_page_addr_t phys1,
PageDesc **ret_p2, tb_page_addr_t phys2, int alloc); PageDesc **ret_p2, tb_page_addr_t phys2, bool alloc);
/* In user-mode page locks aren't used; mmap_lock is enough */ /* In user-mode page locks aren't used; mmap_lock is enough */
#ifdef CONFIG_USER_ONLY #ifdef CONFIG_USER_ONLY
@ -651,7 +651,7 @@ static inline void page_unlock(PageDesc *pd)
/* lock the page(s) of a TB in the correct acquisition order */ /* lock the page(s) of a TB in the correct acquisition order */
static inline void page_lock_tb(const TranslationBlock *tb) static inline void page_lock_tb(const TranslationBlock *tb)
{ {
page_lock_pair(NULL, tb->page_addr[0], NULL, tb->page_addr[1], 0); page_lock_pair(NULL, tb->page_addr[0], NULL, tb->page_addr[1], false);
} }
static inline void page_unlock_tb(const TranslationBlock *tb) static inline void page_unlock_tb(const TranslationBlock *tb)
@ -840,7 +840,7 @@ void page_collection_unlock(struct page_collection *set)
#endif /* !CONFIG_USER_ONLY */ #endif /* !CONFIG_USER_ONLY */
static void page_lock_pair(PageDesc **ret_p1, tb_page_addr_t phys1, static void page_lock_pair(PageDesc **ret_p1, tb_page_addr_t phys1,
PageDesc **ret_p2, tb_page_addr_t phys2, int alloc) PageDesc **ret_p2, tb_page_addr_t phys2, bool alloc)
{ {
PageDesc *p1, *p2; PageDesc *p1, *p2;
tb_page_addr_t page1; tb_page_addr_t page1;
@ -1290,7 +1290,7 @@ tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc,
* Note that inserting into the hash table first isn't an option, since * Note that inserting into the hash table first isn't an option, since
* we can only insert TBs that are fully initialized. * we can only insert TBs that are fully initialized.
*/ */
page_lock_pair(&p, phys_pc, &p2, phys_page2, 1); page_lock_pair(&p, phys_pc, &p2, phys_page2, true);
tb_page_add(p, tb, 0, phys_pc & TARGET_PAGE_MASK); tb_page_add(p, tb, 0, phys_pc & TARGET_PAGE_MASK);
if (p2) { if (p2) {
tb_page_add(p2, tb, 1, phys_page2); tb_page_add(p2, tb, 1, phys_page2);
@ -2219,7 +2219,7 @@ void page_set_flags(target_ulong start, target_ulong end, int flags)
for (addr = start, len = end - start; for (addr = start, len = end - start;
len != 0; len != 0;
len -= TARGET_PAGE_SIZE, addr += TARGET_PAGE_SIZE) { len -= TARGET_PAGE_SIZE, addr += TARGET_PAGE_SIZE) {
PageDesc *p = page_find_alloc(addr >> TARGET_PAGE_BITS, 1); PageDesc *p = page_find_alloc(addr >> TARGET_PAGE_BITS, true);
/* If the write protection bit is set, then we invalidate /* If the write protection bit is set, then we invalidate
the code inside. */ the code inside. */