mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/sd/bcm2835_sdhost: Don't raise spurious interrupts

Browse Source 
The Linux bcm2835_sdhost driver doesn't work on QEMU, because our
model raises spurious data interrupts.  Our function
bcm2835_sdhost_fifo_run() will flag an interrupt any time it is
called with s->datacnt == 0, even if the host hasn't actually issued
a data read or write command yet.  This means that the driver gets a
spurious data interrupt as soon as it enables IRQs and then does
something else that causes us to call the fifo_run routine, like
writing to SDHCFG, and before it does the write to SDCMD to issue the
read.  The driver's IRQ handler then spins forever complaining that
there's no data and the SD controller isn't in a state where there's
going to be any data:

[   41.040738] sdhost-bcm2835 3f202000.mmc: fsm 1, hsts 00000000
[   41.042059] sdhost-bcm2835 3f202000.mmc: fsm 1, hsts 00000000
(continues forever).

Move the interrupt flag setting to more plausible places:
 * for BUSY, raise this as soon as a BUSYWAIT command has executed
 * for DATA, raise this when the FIFO has any space free (for a write)
   or any data in it (for a read)
 * for BLOCK, raise this when the data count is 0 and we've
   actually done some reading or writing

This is pure guesswork since the documentation for this hardware is
not public, but it is sufficient to get the Linux bcm2835_sdhost
driver to work.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20180319161556.16446-3-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2018-04-10 13:02:25 +01:00
parent b318f3265c
commit f3d9fe8f95
1 changed files with 26 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
hw/sd/bcm2835_sdhost.c
View File

@ -137,6 +137,12 @@ static void bcm2835_sdhost_send_command(BCM2835SDHostState *s)
} }
#undef RWORD #undef RWORD
} }
/* We never really delay commands, so if this was a 'busywait' command
* then we've completed it now and can raise the interrupt.
*/
if ((s->cmd & SDCMD_BUSYWAIT) && (s->config & SDHCFG_BUSY_IRPT_EN)) {
s->status |= SDHSTS_BUSY_IRPT;
}
return; return;
error: error:
@ -187,18 +193,27 @@ static void bcm2835_sdhost_fifo_run(BCM2835SDHostState *s)
n++; n++;
if (n == 4) { if (n == 4) {
bcm2835_sdhost_fifo_push(s, value); bcm2835_sdhost_fifo_push(s, value);
s->status |= SDHSTS_DATA_FLAG;
if (s->config & SDHCFG_DATA_IRPT_EN) {
s->status |= SDHSTS_SDIO_IRPT;
}
n = 0; n = 0;
value = 0; value = 0;
} }
} }
if (n != 0) { if (n != 0) {
bcm2835_sdhost_fifo_push(s, value); bcm2835_sdhost_fifo_push(s, value);
s->status |= SDHSTS_DATA_FLAG;
} }
} else { /* write */ } else { /* write */
n = 0; n = 0;
while (s->datacnt > 0 && (s->fifo_len > 0 || n > 0)) { while (s->datacnt > 0 && (s->fifo_len > 0 || n > 0)) {
if (n == 0) { if (n == 0) {
value = bcm2835_sdhost_fifo_pop(s); value = bcm2835_sdhost_fifo_pop(s);
s->status |= SDHSTS_DATA_FLAG;
if (s->config & SDHCFG_DATA_IRPT_EN) {
s->status |= SDHSTS_SDIO_IRPT;
}
n = 4; n = 4;
} }
n--; n--;
@ -207,28 +222,19 @@ static void bcm2835_sdhost_fifo_run(BCM2835SDHostState *s)
value >>= 8; value >>= 8;
} }
} }
}
if (s->datacnt == 0) { if (s->datacnt == 0) {
s->status |= SDHSTS_DATA_FLAG; s->edm &= ~SDEDM_FSM_MASK;
s->edm &= ~0xf;
s->edm |= SDEDM_FSM_DATAMODE; s->edm |= SDEDM_FSM_DATAMODE;
trace_bcm2835_sdhost_edm_change("datacnt 0", s->edm); trace_bcm2835_sdhost_edm_change("datacnt 0", s->edm);
if (s->config & SDHCFG_DATA_IRPT_EN) { if ((s->cmd & SDCMD_WRITE_CMD) &&
s->status |= SDHSTS_SDIO_IRPT; (s->config & SDHCFG_BLOCK_IRPT_EN)) {
}
if ((s->cmd & SDCMD_BUSYWAIT) && (s->config & SDHCFG_BUSY_IRPT_EN)) {
s->status |= SDHSTS_BUSY_IRPT;
}
if ((s->cmd & SDCMD_WRITE_CMD) && (s->config & SDHCFG_BLOCK_IRPT_EN)) {
s->status |= SDHSTS_BLOCK_IRPT; s->status |= SDHSTS_BLOCK_IRPT;
} }
}
}
bcm2835_sdhost_update_irq(s); bcm2835_sdhost_update_irq(s);
}
s->edm &= ~(0x1f << 4); s->edm &= ~(0x1f << 4);
s->edm |= ((s->fifo_len & 0x1f) << 4); s->edm |= ((s->fifo_len & 0x1f) << 4);