mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

block: add empty account cookie type

Browse Source 
Each block_acct_done/failed call is designed to correspond to a
previous block_acct_start call, which initializes the stats cookie.
However sometimes it is not the case, e.g. some error paths might
report the same cookie twice because it is hard to accurately track if
the cookie was reported yet or not.

This patch cleans the cookie after report.
(Note: block_acct_failed/done without a previous block_acct_start at
all should be avoided. Uninitialized cookie might hold a garbage value
and there is still "< BLOCK_MAX_IOTYPE" assertion for that)

It will be particularly useful in ide code where it's hard to
keep track whether the request done its accounting or not: in the
following patch of the series, trim requests will do the accounting
separately.

Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20190923121737.83281-4-anton.nefedov@virtuozzo.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
This commit is contained in:
Anton Nefedov 2019-09-23 15:17:31 +03:00 committed by Max Reitz
parent 159f85ddc8
commit f344446654
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
block/accounting.c
View File

@ -195,6 +195,10 @@ static void block_account_one_io(BlockAcctStats *stats, BlockAcctCookie *cookie,
assert(cookie->type < BLOCK_MAX_IOTYPE); assert(cookie->type < BLOCK_MAX_IOTYPE);
if (cookie->type == BLOCK_ACCT_NONE) {
return;
}
qemu_mutex_lock(&stats->lock); qemu_mutex_lock(&stats->lock);
if (failed) { if (failed) {
@ -217,6 +221,8 @@ static void block_account_one_io(BlockAcctStats *stats, BlockAcctCookie *cookie,
} }
qemu_mutex_unlock(&stats->lock); qemu_mutex_unlock(&stats->lock);
cookie->type = BLOCK_ACCT_NONE;
} }
void block_acct_done(BlockAcctStats *stats, BlockAcctCookie *cookie) void block_acct_done(BlockAcctStats *stats, BlockAcctCookie *cookie)

1
include/block/accounting.h
View File

@ -33,6 +33,7 @@ typedef struct BlockAcctTimedStats BlockAcctTimedStats;
typedef struct BlockAcctStats BlockAcctStats; typedef struct BlockAcctStats BlockAcctStats;
enum BlockAcctType { enum BlockAcctType {
BLOCK_ACCT_NONE = 0,
BLOCK_ACCT_READ, BLOCK_ACCT_READ,
BLOCK_ACCT_WRITE, BLOCK_ACCT_WRITE,
BLOCK_ACCT_FLUSH, BLOCK_ACCT_FLUSH,