mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

allwinner-i2c, adm1272: Use device_cold_reset() for software-triggered reset

Browse Source 
Rather than directly calling the device's implementation of its 'hold'
reset phase, call device_cold_reset(). This means we don't have to
adjust this callsite when we add another argument to the function
signature for the hold and exit reset methods.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Luc Michel <luc.michel@amd.com>
Message-id: 20240412160809.1260625-3-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2024-04-12 17:08:05 +01:00
parent 1e0f2b38ac
commit ef6ab2922f
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/i2c/allwinner-i2c.c
View File

@ -385,8 +385,7 @@ static void allwinner_i2c_write(void *opaque, hwaddr offset,
break;
case TWI_SRST_REG:
if (((value & TWI_SRST_MASK) == 0) && (s->srst & TWI_SRST_MASK)) {
/* Perform reset */
allwinner_i2c_reset_hold(OBJECT(s));
device_cold_reset(DEVICE(s));
}
s->srst = value & TWI_SRST_MASK;
break;

2
hw/sensor/adm1272.c
View File

@ -386,7 +386,7 @@ static int adm1272_write_data(PMBusDevice *pmdev, const uint8_t *buf,
break;
case ADM1272_MFR_POWER_CYCLE:
adm1272_exit_reset((Object *)s);
device_cold_reset(DEVICE(s));
break;
case ADM1272_HYSTERESIS_LOW: