mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libcacard: don't leak vcard_emul_alloc_arrays mem

Browse Source 
vcard_emul_mirror_card and vcard_emul_init use
vcard_emul_alloc_arrays to allocate memory for temporary arrays
which will contain elements that in the end will be used one by
one in cac_card_init. The arrays themselves are never stored
anywhere, they are only used as temporary containers. Hence
the memory that was allocated for these arrays should be freed
after use or they will be leaked.
This commit is contained in:
Christophe Fergeau 2011-07-04 18:10:43 +02:00 committed by Alon Levy
parent 010debef61
commit ee83d41466
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libcacard/vcard_emul_nss.c
View File

@ -597,6 +597,7 @@ vcard_emul_mirror_card(VReader *vreader)
VCardKey **keys;
PK11SlotInfo *slot;
PRBool ret;
VCard *card;
slot = vcard_emul_reader_get_slot(vreader);
if (slot == NULL) {
@ -656,7 +657,12 @@ vcard_emul_mirror_card(VReader *vreader)
}
/* now create the card */
return vcard_emul_make_card(vreader, certs, cert_len, keys, cert_count);
card = vcard_emul_make_card(vreader, certs, cert_len, keys, cert_count);
qemu_free(certs);
qemu_free(cert_len);
qemu_free(keys);
return card;
}
static VCardEmulType default_card_type = VCARD_EMUL_NONE;
@ -941,6 +947,9 @@ vcard_emul_init(const VCardEmulOptions *options)
vreader_free(vreader);
has_readers = PR_TRUE;
}
qemu_free(certs);
qemu_free(cert_len);
qemu_free(keys);
}
/* if we aren't suppose to use hw, skip looking up hardware tokens */