qapi: do not protect enum values from namespace pollution
Enum values are always preceded by the uppercase name of the enum, so they do not conflict with reserved words. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This commit is contained in:
parent
f513cbf750
commit
eda50a656f
@ -91,9 +91,9 @@ const char *%(name)s_lookup[] = {
|
||||
|
||||
def generate_enum_name(name):
|
||||
if name.isupper():
|
||||
return c_fun(name)
|
||||
return c_fun(name, False)
|
||||
new_name = ''
|
||||
for c in c_fun(name):
|
||||
for c in c_fun(name, False):
|
||||
if c.isupper():
|
||||
new_name += '_'
|
||||
new_name += c
|
||||
|
@ -173,7 +173,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **
|
||||
break;
|
||||
''',
|
||||
abbrev = de_camel_case(name).upper(),
|
||||
enum = c_fun(de_camel_case(key)).upper(),
|
||||
enum = c_fun(de_camel_case(key),False).upper(),
|
||||
c_type=members[key],
|
||||
c_name=c_fun(key))
|
||||
|
||||
|
@ -141,7 +141,7 @@ def camel_case(name):
|
||||
new_name += ch.lower()
|
||||
return new_name
|
||||
|
||||
def c_var(name):
|
||||
def c_var(name, protect=True):
|
||||
# ANSI X3J11/88-090, 3.1.1
|
||||
c89_words = set(['auto', 'break', 'case', 'char', 'const', 'continue',
|
||||
'default', 'do', 'double', 'else', 'enum', 'extern', 'float',
|
||||
@ -156,12 +156,12 @@ def c_var(name):
|
||||
# GCC http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc/C-Extensions.html
|
||||
# excluding _.*
|
||||
gcc_words = set(['asm', 'typeof'])
|
||||
if name in c89_words | c99_words | c11_words | gcc_words:
|
||||
if protect and (name in c89_words | c99_words | c11_words | gcc_words):
|
||||
return "q_" + name
|
||||
return name.replace('-', '_').lstrip("*")
|
||||
|
||||
def c_fun(name):
|
||||
return c_var(name).replace('.', '_')
|
||||
def c_fun(name, protect=True):
|
||||
return c_var(name, protect).replace('.', '_')
|
||||
|
||||
def c_list_type(name):
|
||||
return '%sList' % name
|
||||
|
Loading…
Reference in New Issue
Block a user