mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdbstub: tidy away reverse debugging check into function

Browse Source 
In theory we don't need an actual record/replay to enact reverse
debugging on a purely deterministic system (i.e one with no external
inputs running under icount). Tidy away the logic into a little
function.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210520174303.12310-8-alex.bennee@linaro.org>
This commit is contained in:
Alex Bennée 2021-05-20 18:43:02 +01:00
parent ae49ce0019
commit ed12f5b4ef
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gdbstub.c
View File

@ -465,6 +465,15 @@ int use_gdb_syscalls(void)
return gdb_syscall_mode == GDB_SYS_ENABLED; return gdb_syscall_mode == GDB_SYS_ENABLED;
} }
static bool stub_can_reverse(void)
{
#ifdef CONFIG_USER_ONLY
return false;
#else
return replay_mode == REPLAY_MODE_PLAY;
#endif
}
/* Resume execution. */ /* Resume execution. */
static inline void gdb_continue(void) static inline void gdb_continue(void)
{ {
@ -1880,7 +1889,7 @@ static void handle_step(GArray *params, void *user_ctx)
static void handle_backward(GArray *params, void *user_ctx) static void handle_backward(GArray *params, void *user_ctx)
{ {
if (replay_mode != REPLAY_MODE_PLAY) { if (!stub_can_reverse()) {
put_packet("E22"); put_packet("E22");
} }
if (params->len == 1) { if (params->len == 1) {
@ -2153,7 +2162,7 @@ static void handle_query_supported(GArray *params, void *user_ctx)
g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+"); g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+");
} }
if (replay_mode == REPLAY_MODE_PLAY) { if (stub_can_reverse()) {
g_string_append(gdbserver_state.str_buf, g_string_append(gdbserver_state.str_buf,
";ReverseStep+;ReverseContinue+"); ";ReverseStep+;ReverseContinue+");
} }