mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qemu-bridge-helper: Fix fd leak in main()

Browse Source 
initialize fd and ctlfd, and close them at the end

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Gonglei 2014-06-10 17:20:25 +08:00 committed by Stefan Hajnoczi
parent ff4873cb8c
commit eb3f45c5af
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
qemu-bridge-helper.c
View File

@ -229,7 +229,7 @@ int main(int argc, char **argv)
unsigned long ifargs[4]; unsigned long ifargs[4];
#endif #endif
int ifindex; int ifindex;
int fd, ctlfd, unixfd = -1; int fd = -1, ctlfd = -1, unixfd = -1;
int use_vnet = 0; int use_vnet = 0;
int mtu; int mtu;
const char *bridge = NULL; const char *bridge = NULL;
@ -436,7 +436,12 @@ int main(int argc, char **argv)
/* profit! */ /* profit! */
cleanup: cleanup:
if (fd >= 0) {
close(fd);
}
if (ctlfd >= 0) {
close(ctlfd);
}
while ((acl_rule = QSIMPLEQ_FIRST(&acl_list)) != NULL) { while ((acl_rule = QSIMPLEQ_FIRST(&acl_list)) != NULL) {
QSIMPLEQ_REMOVE_HEAD(&acl_list, entry); QSIMPLEQ_REMOVE_HEAD(&acl_list, entry);
g_free(acl_rule); g_free(acl_rule);