mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

A branch insn must not overwrite the branch target before relocation.

Browse Source 
When a branch to label is translated it generates a reloc that is filled in
when the label is translated.  However, when handling an exception and
searching for the pc we abort the translation early and we sometimes
translate the branch but not the corresponding label and so no relocation
is done.  When the block is executed again the branch points to no-where.

It seems tcg/sparc/ is going to suffer from the same issue.


git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4547 c046a42c-6fe2-441c-8c8c-71466251a162
This commit is contained in:
balrog 2008-05-23 18:50:44 +00:00
parent f0b3f3ae5d
commit e936243aca
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tcg/arm/tcg-target.c
View File

@ -78,8 +78,8 @@ static void patch_reloc(uint8_t *code_ptr, int type,
tcg_abort(); tcg_abort();
case R_ARM_PC24: case R_ARM_PC24:
*(uint32_t *) code_ptr |= *(uint32_t *) code_ptr |= (*(uint32_t *) code_ptr & 0xff000000) |
((value - ((tcg_target_long) code_ptr + 8)) >> 2) & 0xffffff; (((value - ((tcg_target_long) code_ptr + 8)) >> 2) & 0xffffff);
break; break;
} }
} }
@ -272,6 +272,17 @@ static inline void tcg_out_b(TCGContext *s, int cond, int32_t offset)
(((offset - 8) >> 2) & 0x00ffffff)); (((offset - 8) >> 2) & 0x00ffffff));
} }
static inline void tcg_out_b_noaddr(TCGContext *s, int cond)
{
#ifdef WORDS_BIGENDIAN
tcg_out8(s, (cond << 4) | 0x0a);
s->code_ptr += 3;
#else
s->code_ptr += 3;
tcg_out8(s, (cond << 4) | 0x0a);
#endif
}
static inline void tcg_out_bl(TCGContext *s, int cond, int32_t offset) static inline void tcg_out_bl(TCGContext *s, int cond, int32_t offset)
{ {
tcg_out32(s, (cond << 28) | 0x0b000000 | tcg_out32(s, (cond << 28) | 0x0b000000 |
@ -734,7 +745,7 @@ static inline void tcg_out_goto_label(TCGContext *s, int cond, int label_index)
} else { } else {
/* Probably this should be preferred even for COND_AL... */ /* Probably this should be preferred even for COND_AL... */
tcg_out_reloc(s, s->code_ptr, R_ARM_PC24, label_index, 31337); tcg_out_reloc(s, s->code_ptr, R_ARM_PC24, label_index, 31337);
tcg_out_b(s, cond, 8); tcg_out_b_noaddr(s, cond);
} }
} }