mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests/unit/socket-helpers: Don't close(-1)

Browse Source 
In socket_check_afunix_support() we call socket(PF_UNIX, SOCK_STREAM, 0)
to see if it works, but we call close() on the result whether it
worked or not. Only close the fd if the socket() call succeeded.
Spotted by Coverity.

Resolves: Coverity CID 1497481

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 20240312183810.557768-3-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2024-03-25 10:41:00 +00:00
parent 80e9791a93
commit e921e00d4b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/socket-helpers.c
View File

@ -160,7 +160,6 @@ void socket_check_afunix_support(bool *has_afunix)
int fd; int fd;
fd = socket(PF_UNIX, SOCK_STREAM, 0); fd = socket(PF_UNIX, SOCK_STREAM, 0);
close(fd);
#ifdef _WIN32 #ifdef _WIN32
*has_afunix = (fd != (int)INVALID_SOCKET); *has_afunix = (fd != (int)INVALID_SOCKET);
@ -168,5 +167,8 @@ void socket_check_afunix_support(bool *has_afunix)
*has_afunix = (fd >= 0); *has_afunix = (fd >= 0);
#endif #endif
if (*has_afunix) {
close(fd);
}
return; return;
} }