mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libvduse: Fix the incorrect function name

Browse Source 
In vduse_name_is_valid(), we actually check whether
the name is invalid or not. So let's change the
function name to vduse_name_is_invalid() to match
the behavior.

Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20220706095624.328-2-xieyongji@bytedance.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Xie Yongji 2022-07-06 17:56:22 +08:00 committed by Kevin Wolf
parent 77e3f038af
commit e7156ff7cb
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
subprojects/libvduse/libvduse.c
View File

@ -1193,7 +1193,7 @@ static int vduse_dev_init(VduseDev *dev, const char *name,
return 0; return 0;
} }
static inline bool vduse_name_is_valid(const char *name) static inline bool vduse_name_is_invalid(const char *name)
{ {
return strlen(name) >= VDUSE_NAME_MAX || strstr(name, ".."); return strlen(name) >= VDUSE_NAME_MAX || strstr(name, "..");
} }
@ -1242,7 +1242,7 @@ VduseDev *vduse_dev_create_by_name(const char *name, uint16_t num_queues,
VduseDev *dev; VduseDev *dev;
int ret; int ret;
if (!name || vduse_name_is_valid(name) || !ops || if (!name || vduse_name_is_invalid(name) || !ops ||
!ops->enable_queue || !ops->disable_queue) { !ops->enable_queue || !ops->disable_queue) {
fprintf(stderr, "Invalid parameter for vduse\n"); fprintf(stderr, "Invalid parameter for vduse\n");
return NULL; return NULL;
@ -1276,7 +1276,7 @@ VduseDev *vduse_dev_create(const char *name, uint32_t device_id,
struct vduse_dev_config *dev_config; struct vduse_dev_config *dev_config;
size_t size = offsetof(struct vduse_dev_config, config); size_t size = offsetof(struct vduse_dev_config, config);
if (!name || vduse_name_is_valid(name) || if (!name || vduse_name_is_invalid(name) ||
!has_feature(features, VIRTIO_F_VERSION_1) || !config || !has_feature(features, VIRTIO_F_VERSION_1) || !config ||
!config_size || !ops || !ops->enable_queue || !ops->disable_queue) { !config_size || !ops || !ops->enable_queue || !ops->disable_queue) {
fprintf(stderr, "Invalid parameter for vduse\n"); fprintf(stderr, "Invalid parameter for vduse\n");