mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

memory: Access MemoryRegion with MemOp

Browse Source 
Convert memory_region_dispatch_{read|write} operand "unsigned size"
into a "MemOp op".

Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <1dd82df5801866743f838f1d046475115a1d32da.1566466906.git.tony.nguyen@bt.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Tony Nguyen 2019-08-24 04:36:48 +10:00 committed by Richard Henderson
parent 4cbb198eef
commit e67c904668
3 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
include/exec/memop.h
View File

@ -12,6 +12,8 @@
#ifndef MEMOP_H #ifndef MEMOP_H
#define MEMOP_H #define MEMOP_H
#include "qemu/host-utils.h"
typedef enum MemOp { typedef enum MemOp {
MO_8 = 0, MO_8 = 0,
MO_16 = 1, MO_16 = 1,
@ -107,14 +109,20 @@ typedef enum MemOp {
MO_SSIZE = MO_SIZE | MO_SIGN, MO_SSIZE = MO_SIZE | MO_SIGN,
} MemOp; } MemOp;
/* Size in bytes to MemOp. */ /* MemOp to size in bytes. */
static inline unsigned size_memop(unsigned size) static inline unsigned memop_size(MemOp op)
{ {
/* return 1 << (op & MO_SIZE);
* FIXME: No-op to aid conversion of memory_region_dispatch_{read|write} }
* "unsigned size" operand into a "MemOp op".
*/ /* Size in bytes to MemOp. */
return size; static inline MemOp size_memop(unsigned size)
{
#ifdef CONFIG_DEBUG_TCG
/* Power of 2 up to 8. */
assert((size & (size - 1)) == 0 && size >= 1 && size <= 8);
#endif
return ctz32(size);
} }
#endif #endif

9
include/exec/memory.h
View File

@ -19,6 +19,7 @@
#include "exec/cpu-common.h" #include "exec/cpu-common.h"
#include "exec/hwaddr.h" #include "exec/hwaddr.h"
#include "exec/memattrs.h" #include "exec/memattrs.h"
#include "exec/memop.h"
#include "exec/ramlist.h" #include "exec/ramlist.h"
#include "qemu/bswap.h" #include "qemu/bswap.h"
#include "qemu/queue.h" #include "qemu/queue.h"
@ -1749,13 +1750,13 @@ void mtree_info(bool flatview, bool dispatch_tree, bool owner);
* @mr: #MemoryRegion to access * @mr: #MemoryRegion to access
* @addr: address within that region * @addr: address within that region
* @pval: pointer to uint64_t which the data is written to * @pval: pointer to uint64_t which the data is written to
* @size: size of the access in bytes * @op: size, sign, and endianness of the memory operation
* @attrs: memory transaction attributes to use for the access * @attrs: memory transaction attributes to use for the access
*/ */
MemTxResult memory_region_dispatch_read(MemoryRegion *mr, MemTxResult memory_region_dispatch_read(MemoryRegion *mr,
hwaddr addr, hwaddr addr,
uint64_t *pval, uint64_t *pval,
unsigned size, MemOp op,
MemTxAttrs attrs); MemTxAttrs attrs);
/** /**
* memory_region_dispatch_write: perform a write directly to the specified * memory_region_dispatch_write: perform a write directly to the specified
@ -1764,13 +1765,13 @@ MemTxResult memory_region_dispatch_read(MemoryRegion *mr,
* @mr: #MemoryRegion to access * @mr: #MemoryRegion to access
* @addr: address within that region * @addr: address within that region
* @data: data to write * @data: data to write
* @size: size of the access in bytes * @op: size, sign, and endianness of the memory operation
* @attrs: memory transaction attributes to use for the access * @attrs: memory transaction attributes to use for the access
*/ */
MemTxResult memory_region_dispatch_write(MemoryRegion *mr, MemTxResult memory_region_dispatch_write(MemoryRegion *mr,
hwaddr addr, hwaddr addr,
uint64_t data, uint64_t data,
unsigned size, MemOp op,
MemTxAttrs attrs); MemTxAttrs attrs);
/** /**

7
memory.c
View File

@ -1446,9 +1446,10 @@ static MemTxResult memory_region_dispatch_read1(MemoryRegion *mr,
MemTxResult memory_region_dispatch_read(MemoryRegion *mr, MemTxResult memory_region_dispatch_read(MemoryRegion *mr,
hwaddr addr, hwaddr addr,
uint64_t *pval, uint64_t *pval,
unsigned size, MemOp op,
MemTxAttrs attrs) MemTxAttrs attrs)
{ {
unsigned size = memop_size(op);
MemTxResult r; MemTxResult r;
if (!memory_region_access_valid(mr, addr, size, false, attrs)) { if (!memory_region_access_valid(mr, addr, size, false, attrs)) {
@ -1490,9 +1491,11 @@ static bool memory_region_dispatch_write_eventfds(MemoryRegion *mr,
MemTxResult memory_region_dispatch_write(MemoryRegion *mr, MemTxResult memory_region_dispatch_write(MemoryRegion *mr,
hwaddr addr, hwaddr addr,
uint64_t data, uint64_t data,
unsigned size, MemOp op,
MemTxAttrs attrs) MemTxAttrs attrs)
{ {
unsigned size = memop_size(op);
if (!memory_region_access_valid(mr, addr, size, true, attrs)) { if (!memory_region_access_valid(mr, addr, size, true, attrs)) {
unassigned_mem_write(mr, addr, data, size); unassigned_mem_write(mr, addr, data, size);
return MEMTX_DECODE_ERROR; return MEMTX_DECODE_ERROR;