mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pci: fix double free of romfile property

Browse Source 
The qdev property release function frees any string properties.  This was
resulting in a double free during hot unplug.

It manifests in network devices because block devices have a NULL romfile
property by default.

Cc: Michael Tsirkin <mst@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Anthony Liguori 2012-03-15 11:29:56 -05:00
parent ae7d54d489
commit e5ab1404d0
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hw/pci.c
View File

@ -841,7 +841,6 @@ static int pci_unregister_device(DeviceState *dev)
pci_unregister_io_regions(pci_dev); pci_unregister_io_regions(pci_dev);
pci_del_option_rom(pci_dev); pci_del_option_rom(pci_dev);
g_free(pci_dev->romfile);
do_pci_unregister_device(pci_dev); do_pci_unregister_device(pci_dev);
return 0; return 0;
} }