From 7e75e33e7886314490305f181065b8b4ec916a8a Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Fri, 16 Aug 2013 21:51:53 +0200 Subject: [PATCH 1/3] w32: Fix broken out-of-tree builds (missing version.o) Commit 0b516ef0dfad9a7b34c675c98e8ec92ab4d38466 added version.o to all executables, but broke out-of-tree builds: for those builds the pattern rule %.o: %.rc from rules.mak does not match, so version.o was no longer built. Adding explicit build rules fixes this. Reported-by: Michael Roth Signed-off-by: Stefan Weil Tested-by: Michael Roth --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index 4d257f1a52..806946e339 100644 --- a/Makefile +++ b/Makefile @@ -168,7 +168,9 @@ recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES) bt-host.o: QEMU_CFLAGS += $(BLUEZ_CFLAGS) $(BUILD_DIR)/version.o: $(SRC_PATH)/version.rc $(BUILD_DIR)/config-host.h | $(BUILD_DIR)/version.lo + $(call quiet-command,$(WINDRES) -I$(BUILD_DIR) -o $@ $<," RC version.o") $(BUILD_DIR)/version.lo: $(SRC_PATH)/version.rc $(BUILD_DIR)/config-host.h + $(call quiet-command,$(WINDRES) -I$(BUILD_DIR) -o $@ $<," RC version.lo") Makefile: $(version-obj-y) $(version-lobj-y) From 487cddb2bf3f429953dc5b3252d2a3b83d7200c5 Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Sat, 17 Aug 2013 09:32:04 +0200 Subject: [PATCH 2/3] w32: Add an icon resource The QEMU mascot which was already used for the NSIS installer is now used for all QEMU executables. Signed-off-by: Stefan Weil --- version.rc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/version.rc b/version.rc index 82e10ecf26..a50d62fa0c 100644 --- a/version.rc +++ b/version.rc @@ -26,3 +26,5 @@ FILESUBTYPE VFT2_UNKNOWN VALUE "Translation", 0x0409, 1252 } } + +IDI_ICON1 ICON "pc-bios/qemu-nsis.ico" From 92f1623663a8797e68a043ec401a740746439f29 Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Sun, 18 Aug 2013 09:26:34 +0200 Subject: [PATCH 3/3] gtk: Remove unused include statements which are not portable These include files don't exist for MinGW and are not needed for Linux (and hopefully for other hosts as well), so remove them. Signed-off-by: Stefan Weil --- ui/gtk.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index c38146f80f..b5f4f0bd40 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -51,10 +51,6 @@ #include #include #include -#include -#include -#include -#include #include #include "ui/console.h"