mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests/qtest: migration-test: Avoid using hardcoded /tmp

Browse Source 
This case was written to use hardcoded /tmp directory for temporary
files. Update to use g_dir_make_tmp() for a portable implementation.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20221006151927.2079583-5-bmeng.cn@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Bin Meng 2022-10-06 23:19:13 +08:00 committed by Thomas Huth
parent f57559891d
commit e5553c1b8d
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/qtest/migration-test.c
View File

@ -102,7 +102,7 @@ static bool ufd_version_check(void)
#endif #endif
static const char *tmpfs; static char *tmpfs;
/* The boot file modifies memory area in [start_address, end_address) /* The boot file modifies memory area in [start_address, end_address)
* repeatedly. It outputs a 'B' at a fixed rate while it's still running. * repeatedly. It outputs a 'B' at a fixed rate while it's still running.
@ -2451,10 +2451,10 @@ static bool kvm_dirty_ring_supported(void)
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
char template[] = "/tmp/migration-test-XXXXXX";
const bool has_kvm = qtest_has_accel("kvm"); const bool has_kvm = qtest_has_accel("kvm");
const bool has_uffd = ufd_version_check(); const bool has_uffd = ufd_version_check();
const char *arch = qtest_get_arch(); const char *arch = qtest_get_arch();
g_autoptr(GError) err = NULL;
int ret; int ret;
g_test_init(&argc, &argv, NULL); g_test_init(&argc, &argv, NULL);
@ -2479,9 +2479,10 @@ int main(int argc, char **argv)
return g_test_run(); return g_test_run();
} }
tmpfs = g_mkdtemp(template); tmpfs = g_dir_make_tmp("migration-test-XXXXXX", &err);
if (!tmpfs) { if (!tmpfs) {
g_test_message("g_mkdtemp on path (%s): %s", template, strerror(errno)); g_test_message("g_dir_make_tmp on path (%s): %s", tmpfs,
err->message);
} }
g_assert(tmpfs); g_assert(tmpfs);
@ -2612,6 +2613,7 @@ int main(int argc, char **argv)
g_test_message("unable to rmdir: path (%s): %s", g_test_message("unable to rmdir: path (%s): %s",
tmpfs, strerror(errno)); tmpfs, strerror(errno));
} }
g_free(tmpfs);
return ret; return ret;
} }