mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

exec_close(): return -errno on errors (v2)

Browse Source 
All qemu_fclose() callers were already changed to accept any negative
value as error, so we now can change it to return -errno.

When the process exits with a non-zero exit code, we return -EIO to as a
fake errno value.

Changes v1 -> v2:
 - Don't use "//" comments, to make checkpatch.pl happy

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Eduardo Habkost 2011-11-10 10:41:46 -02:00 committed by Anthony Liguori
parent 0e28670519
commit e375fe3472
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
migration-exec.c
View File

@ -50,12 +50,9 @@ static int exec_close(MigrationState *s)
ret = qemu_fclose(s->opaque); ret = qemu_fclose(s->opaque);
s->opaque = NULL; s->opaque = NULL;
s->fd = -1; s->fd = -1;
if (ret >= 0 && if (ret >= 0 && !(WIFEXITED(ret) && WEXITSTATUS(ret) == 0)) {
WIFEXITED(ret) /* close succeeded, but non-zero exit code: */
&& WEXITSTATUS(ret) == 0) { ret = -EIO; /* fake errno value */
ret = 0;
} else {
ret = -1;
} }
} }
return ret; return ret;