mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/guest-random: Fix size arg to tail memcpy

Browse Source 
We know that in the body of this if statement i is less than len, so
we really should be copying len - i bytes not i - len bytes.

Fix this typo.

Fixes: 8d8404f156 ("util: Add qemu_guest_getrandom and associated routines")
Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210709120600.11080-1-mdnelson8@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Mark Nelson 2021-07-09 07:06:00 -05:00 committed by Laurent Vivier
parent 179a808045
commit e28ffe90fd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/guest-random.c
View File

@ -38,7 +38,7 @@ static int glib_random_bytes(void *buf, size_t len)
} }
if (i < len) { if (i < len) {
x = g_rand_int(rand); x = g_rand_int(rand);
__builtin_memcpy(buf + i, &x, i - len); __builtin_memcpy(buf + i, &x, len - i);
} }
return 0; return 0;
} }