mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: ehci: add capability mmio write function

Browse Source 
USB Ehci emulation supports host controller capability registers.
But its mmio '.write' function was missing, which lead to a null
pointer dereference issue. Add a do nothing 'ehci_caps_write'
definition to avoid it; Do nothing because capability registers
are Read Only(RO).

Reported-by: Zuozhi Fzz <zuozhi.fzz@alibaba-inc.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-id: 1454072434-16045-1-git-send-email-ppandit@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Prasad J Pandit 2016-01-29 18:30:34 +05:30 committed by Gerd Hoffmann
parent 983bff3530
commit dff0367cf6
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/usb/hcd-ehci.c
View File

@ -895,6 +895,11 @@ static uint64_t ehci_caps_read(void *ptr, hwaddr addr,
return s->caps[addr]; return s->caps[addr];
} }
static void ehci_caps_write(void *ptr, hwaddr addr,
uint64_t val, unsigned size)
{
}
static uint64_t ehci_opreg_read(void *ptr, hwaddr addr, static uint64_t ehci_opreg_read(void *ptr, hwaddr addr,
unsigned size) unsigned size)
{ {
@ -2315,6 +2320,7 @@ static void ehci_frame_timer(void *opaque)
static const MemoryRegionOps ehci_mmio_caps_ops = { static const MemoryRegionOps ehci_mmio_caps_ops = {
.read = ehci_caps_read, .read = ehci_caps_read,
.write = ehci_caps_write,
.valid.min_access_size = 1, .valid.min_access_size = 1,
.valid.max_access_size = 4, .valid.max_access_size = 4,
.impl.min_access_size = 1, .impl.min_access_size = 1,