mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/arm: kvm: use RCU_READ_LOCK_GUARD() in kvm_arch_fixup_msi_route()

Browse Source 
As per commit 5626f8c6d4 ("rcu: Add automatically released rcu_read_lock
variants"), RCU_READ_LOCK_GUARD() should be used instead of
rcu_read_{un}lock().

Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20210727235201.11491-1-someguy@effective-light.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Hamza Mahfooz 2021-07-27 19:52:01 -04:00 committed by Peter Maydell
parent e534629296
commit dfa0d9b80e
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
target/arm/kvm.c
View File

@ -998,7 +998,6 @@ int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
hwaddr xlat, len, doorbell_gpa; hwaddr xlat, len, doorbell_gpa;
MemoryRegionSection mrs; MemoryRegionSection mrs;
MemoryRegion *mr; MemoryRegion *mr;
int ret = 1;
if (as == &address_space_memory) { if (as == &address_space_memory) {
return 0; return 0;
@ -1006,15 +1005,19 @@ int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
/* MSI doorbell address is translated by an IOMMU */ /* MSI doorbell address is translated by an IOMMU */
rcu_read_lock(); RCU_READ_LOCK_GUARD();
mr = address_space_translate(as, address, &xlat, &len, true, mr = address_space_translate(as, address, &xlat, &len, true,
MEMTXATTRS_UNSPECIFIED); MEMTXATTRS_UNSPECIFIED);
if (!mr) { if (!mr) {
goto unlock; return 1;
} }
mrs = memory_region_find(mr, xlat, 1); mrs = memory_region_find(mr, xlat, 1);
if (!mrs.mr) { if (!mrs.mr) {
goto unlock; return 1;
} }
doorbell_gpa = mrs.offset_within_address_space; doorbell_gpa = mrs.offset_within_address_space;
@ -1025,11 +1028,7 @@ int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
trace_kvm_arm_fixup_msi_route(address, doorbell_gpa); trace_kvm_arm_fixup_msi_route(address, doorbell_gpa);
ret = 0; return 0;
unlock:
rcu_read_unlock();
return ret;
} }
int kvm_arch_add_msi_route_post(struct kvm_irq_routing_entry *route, int kvm_arch_add_msi_route_post(struct kvm_irq_routing_entry *route,