mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpus: join thread when removing a vCPU

Browse Source 
If no one joins the thread, its associated memory is leaked.

Reported-by: CheneyLin <linzc@zju.edu.cn>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2018-01-30 16:40:12 +01:00
parent 8178e6376f
commit dbadee4ff4
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cpus.c
View File

@ -1752,19 +1752,14 @@ void resume_all_vcpus(void)
} }
} }
void cpu_remove(CPUState *cpu) void cpu_remove_sync(CPUState *cpu)
{ {
cpu->stop = true; cpu->stop = true;
cpu->unplug = true; cpu->unplug = true;
qemu_cpu_kick(cpu); qemu_cpu_kick(cpu);
} qemu_mutex_unlock_iothread();
qemu_thread_join(cpu->thread);
void cpu_remove_sync(CPUState *cpu) qemu_mutex_lock_iothread();
{
cpu_remove(cpu);
while (cpu->created) {
qemu_cond_wait(&qemu_cpu_cond, &qemu_global_mutex);
}
} }
/* For temporary buffers for forming a name */ /* For temporary buffers for forming a name */