mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

can-host-socketcan: Fix crash when 'if' option is not set

Browse Source 
Fix the following crash:

  $ qemu-system-x86_64 -object can-host-socketcan,id=obj0
  Segmentation fault (core dumped)

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Message-Id: <20201008202713.1416823-3-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Eduardo Habkost 2020-10-08 16:27:12 -04:00
parent 14b3948536
commit d9753cca6b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/can/can_socketcan.c
View File

@ -194,6 +194,11 @@ static void can_host_socketcan_connect(CanHostState *ch, Error **errp)
struct sockaddr_can addr; struct sockaddr_can addr;
struct ifreq ifr; struct ifreq ifr;
if (!c->ifname) {
error_setg(errp, "'if' property not set");
return;
}
/* open socket */ /* open socket */
s = qemu_socket(PF_CAN, SOCK_RAW, CAN_RAW); s = qemu_socket(PF_CAN, SOCK_RAW, CAN_RAW);
if (s < 0) { if (s < 0) {