mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

error: Fix "Converting to ERRP_GUARD()" doc on "valid at return"

Browse Source 
Setting errp = NULL is wrong: the automatic error propagation still
propagates the dangling pointer _auto_errp_prop.local_err.  We need to
set *errp = NULL to clear the dangling pointer.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210125132635.1253219-1-armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This commit is contained in:
Markus Armbruster 2021-01-25 14:26:35 +01:00
parent fe352f5c00
commit d71a243220
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/qapi/error.h
View File

@ -235,7 +235,7 @@
* error_propagate_prepend(errp, *errp, ...) by error_prepend(errp, ...) * error_propagate_prepend(errp, *errp, ...) by error_prepend(errp, ...)
* *
* 4. Ensure @errp is valid at return: when you destroy *errp, set * 4. Ensure @errp is valid at return: when you destroy *errp, set
* errp = NULL. * *errp = NULL.
* *
* Example: * Example:
* *