mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hmp/vnc: Fix info vnc list leak

Browse Source 
We're iterating the list, and then freeing the iteration pointer rather
than the list head.

Fixes: 0a9667ecdb ("hmp: Update info vnc")
Reported-by: Coverity (CID 1421932)
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20200323120822.51266-1-dgilbert@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
This commit is contained in:
Dr. David Alan Gilbert 2020-03-23 12:08:22 +00:00
parent 6d1da867e6
commit d4ff109373
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
monitor/hmp-cmds.c
View File

@ -527,10 +527,11 @@ static void hmp_info_vnc_servers(Monitor *mon, VncServerInfo2List *server)
void hmp_info_vnc(Monitor *mon, const QDict *qdict) void hmp_info_vnc(Monitor *mon, const QDict *qdict)
{ {
VncInfo2List *info2l; VncInfo2List *info2l, *info2l_head;
Error *err = NULL; Error *err = NULL;
info2l = qmp_query_vnc_servers(&err); info2l = qmp_query_vnc_servers(&err);
info2l_head = info2l;
if (err) { if (err) {
hmp_handle_error(mon, err); hmp_handle_error(mon, err);
return; return;
@ -559,7 +560,7 @@ void hmp_info_vnc(Monitor *mon, const QDict *qdict)
info2l = info2l->next; info2l = info2l->next;
} }
qapi_free_VncInfo2List(info2l); qapi_free_VncInfo2List(info2l_head);
} }
#endif #endif