mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix off-by-one error in pci_piix3_xen_ide_unplug

Browse Source 
Fix off-by-one error when unplugging disks, which would otherwise leave the last ATA disk plugged, with obvious consequences. Also rewrite loop to be more readable.

Signed-off-by: James Harper <james.harper@ejbdigital.com.au>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
This commit is contained in:
James Harper 2014-10-30 10:08:28 +00:00 committed by Stefano Stabellini
parent 37f9e258b6
commit d4f9e806c2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/ide/piix.c
View File

@ -171,11 +171,11 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev)
{ {
PCIIDEState *pci_ide; PCIIDEState *pci_ide;
DriveInfo *di; DriveInfo *di;
int i = 0; int i;
pci_ide = PCI_IDE(dev); pci_ide = PCI_IDE(dev);
for (; i < 3; i++) { for (i = 0; i < 4; i++) {
di = drive_get_by_index(IF_IDE, i); di = drive_get_by_index(IF_IDE, i);
if (di != NULL && !di->media_cd) { if (di != NULL && !di->media_cd) {
BlockBackend *blk = blk_by_legacy_dinfo(di); BlockBackend *blk = blk_by_legacy_dinfo(di);