mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/rx: Move DISAS_UPDATE check for write to PSW

Browse Source 
Have one check in move_to_cr instead of one in each
function that calls move_to_cr.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20220417165130.695085-4-richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2022-04-17 09:51:29 -07:00
parent 3626a3fe37
commit d3562fe258
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
target/rx/translate.c
View File

@ -368,6 +368,10 @@ static void move_to_cr(DisasContext *ctx, TCGv val, int cr)
switch (cr) { switch (cr) {
case 0: /* PSW */ case 0: /* PSW */
gen_helper_set_psw(cpu_env, val); gen_helper_set_psw(cpu_env, val);
if (is_privileged(ctx, 0)) {
/* PSW.{I,U} may be updated here. exit TB. */
ctx->base.is_jmp = DISAS_UPDATE;
}
break; break;
/* case 1: to PC not supported */ /* case 1: to PC not supported */
case 2: /* USP */ case 2: /* USP */
@ -631,10 +635,6 @@ static bool trans_POPC(DisasContext *ctx, arg_POPC *a)
val = tcg_temp_new(); val = tcg_temp_new();
pop(val); pop(val);
move_to_cr(ctx, val, a->cr); move_to_cr(ctx, val, a->cr);
if (a->cr == 0 && is_privileged(ctx, 0)) {
/* PSW.I may be updated here. exit TB. */
ctx->base.is_jmp = DISAS_UPDATE;
}
tcg_temp_free(val); tcg_temp_free(val);
return true; return true;
} }
@ -2205,9 +2205,6 @@ static bool trans_MVTC_i(DisasContext *ctx, arg_MVTC_i *a)
imm = tcg_const_i32(a->imm); imm = tcg_const_i32(a->imm);
move_to_cr(ctx, imm, a->cr); move_to_cr(ctx, imm, a->cr);
if (a->cr == 0 && is_privileged(ctx, 0)) {
ctx->base.is_jmp = DISAS_UPDATE;
}
tcg_temp_free(imm); tcg_temp_free(imm);
return true; return true;
} }
@ -2216,9 +2213,6 @@ static bool trans_MVTC_i(DisasContext *ctx, arg_MVTC_i *a)
static bool trans_MVTC_r(DisasContext *ctx, arg_MVTC_r *a) static bool trans_MVTC_r(DisasContext *ctx, arg_MVTC_r *a)
{ {
move_to_cr(ctx, cpu_regs[a->rs], a->cr); move_to_cr(ctx, cpu_regs[a->rs], a->cr);
if (a->cr == 0 && is_privileged(ctx, 0)) {
ctx->base.is_jmp = DISAS_UPDATE;
}
return true; return true;
} }