mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

s390x/kvm: Remove redundant return code

Browse Source 
Removed the redundant return code statement from handle_instruction() - it
always returned 0 and never reports any errors to its caller, since errors
from the sub-functions are already reported via program exceptions instead.

Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
This commit is contained in:
Thomas Huth 2013-07-02 14:45:16 +02:00 committed by Christian Borntraeger
parent c1e8dfb5e8
commit d2ee774616
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
target-s390x/kvm.c
View File

@ -693,7 +693,7 @@ out:
return 0; return 0;
} }
static int handle_instruction(S390CPU *cpu, struct kvm_run *run) static void handle_instruction(S390CPU *cpu, struct kvm_run *run)
{ {
unsigned int ipa0 = (run->s390_sieic.ipa & 0xff00); unsigned int ipa0 = (run->s390_sieic.ipa & 0xff00);
uint8_t ipa1 = run->s390_sieic.ipa & 0x00ff; uint8_t ipa1 = run->s390_sieic.ipa & 0x00ff;
@ -719,7 +719,6 @@ static int handle_instruction(S390CPU *cpu, struct kvm_run *run)
if (r < 0) { if (r < 0) {
enter_pgmcheck(cpu, 0x0001); enter_pgmcheck(cpu, 0x0001);
} }
return 0;
} }
static bool is_special_wait_psw(CPUState *cs) static bool is_special_wait_psw(CPUState *cs)
@ -739,7 +738,7 @@ static int handle_intercept(S390CPU *cpu)
(long)cs->kvm_run->psw_addr); (long)cs->kvm_run->psw_addr);
switch (icpt_code) { switch (icpt_code) {
case ICPT_INSTRUCTION: case ICPT_INSTRUCTION:
r = handle_instruction(cpu, run); handle_instruction(cpu, run);
break; break;
case ICPT_WAITPSW: case ICPT_WAITPSW:
/* disabled wait, since enabled wait is handled in kernel */ /* disabled wait, since enabled wait is handled in kernel */