mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

virtio-pmem: fix virtio_pmem_resp assign problem

Browse Source 
ret in virtio_pmem_resp is a uint32_t variable, which should be assigned
using virtio_stl_p.

The kernel side driver does not guarantee virtio_pmem_resp to be initialized
to zero in advance, So sometimes the flush operation will fail.

Signed-off-by: Wang Liang <wangliangzz@inspur.com>
Message-Id: <20210317024145.271212-1-wangliangzz@126.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Wang Liang 2021-03-16 22:41:45 -04:00 committed by Michael S. Tsirkin
parent db8a3772e3
commit d2adda34a9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/virtio/virtio-pmem.c
View File

@ -47,7 +47,7 @@ static int worker_cb(void *opaque)
err = 1;
}
virtio_stw_p(req_data->vdev, &req_data->resp.ret, err);
virtio_stl_p(req_data->vdev, &req_data->resp.ret, err);
return 0;
}