mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libqtest: fix memory leak in the qtest_qmp_event_ref

Browse Source 
The g_list_remove_link doesn't free the link element,
opposed to what I thought.
Switch to g_list_delete_link that does free it.

Also refactor the code a bit.
Thanks for Max Reitz for helping me with this.

Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Message-Id: <20201019163702.471239-4-mlevitsk@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Maxim Levitsky 2020-10-19 19:37:01 +03:00 committed by Thomas Huth
parent 7f9d519c0d
commit d232b87ec6
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/qtest/libqtest.c
View File

@ -795,15 +795,12 @@ void qtest_qmp_send_raw(QTestState *s, const char *fmt, ...)
QDict *qtest_qmp_event_ref(QTestState *s, const char *event)
{
GList *next = NULL;
QDict *response;
while (s->pending_events) {
for (GList *it = s->pending_events; it != NULL; it = next) {
GList *first = s->pending_events;
QDict *response = (QDict *)first->data;
next = it->next;
response = (QDict *)it->data;
s->pending_events = g_list_remove_link(s->pending_events, it);
s->pending_events = g_list_delete_link(s->pending_events, first);
if (!strcmp(qdict_get_str(response, "event"), event)) {
return response;