mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

memory: Make flatview_cb return bool, not int

Browse Source 
The return value of the flatview_cb callback passed to the
flatview_for_each_range() function is zero if the iteration through
the ranges should continue, or non-zero to break out of it.  Use a
bool for this rather than int.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20210318174823.18066-2-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2021-03-18 17:48:19 +00:00
parent e6fa978d83
commit d1e8cf77f1
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/exec/memory.h
View File

@ -776,9 +776,9 @@ static inline FlatView *address_space_to_flatview(AddressSpace *as)
return qatomic_rcu_read(&as->current_map); return qatomic_rcu_read(&as->current_map);
} }
typedef int (*flatview_cb)(Int128 start, typedef bool (*flatview_cb)(Int128 start,
Int128 len, Int128 len,
const MemoryRegion*, void*); const MemoryRegion*, void*);
void flatview_for_each_range(FlatView *fv, flatview_cb cb , void *opaque); void flatview_for_each_range(FlatView *fv, flatview_cb cb , void *opaque);

8
tests/qtest/fuzz/generic_fuzz.c
View File

@ -98,19 +98,19 @@ struct get_io_cb_info {
address_range result; address_range result;
}; };
static int get_io_address_cb(Int128 start, Int128 size, static bool get_io_address_cb(Int128 start, Int128 size,
const MemoryRegion *mr, void *opaque) { const MemoryRegion *mr, void *opaque) {
struct get_io_cb_info *info = opaque; struct get_io_cb_info *info = opaque;
if (g_hash_table_lookup(fuzzable_memoryregions, mr)) { if (g_hash_table_lookup(fuzzable_memoryregions, mr)) {
if (info->index == 0) { if (info->index == 0) {
info->result.addr = (ram_addr_t)start; info->result.addr = (ram_addr_t)start;
info->result.size = (ram_addr_t)size; info->result.size = (ram_addr_t)size;
info->found = 1; info->found = 1;
return 1; return true;
} }
info->index--; info->index--;
} }
return 0; return false;
} }
/* /*