blockdev-test: Use single rather than double quotes in QMP
QMP accepts both single and double quotes. This is the only test using double quotes. They need to be quoted in C strings. Replace them by single quotes. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-id: 1412261496-24455-3-git-send-email-armbru@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
parent
e2f3f22188
commit
d0e3866837
@ -23,9 +23,9 @@ static void test_drive_without_dev(void)
|
||||
qtest_start("-drive if=none,id=drive0");
|
||||
|
||||
/* Delete the drive */
|
||||
response = qmp("{\"execute\": \"human-monitor-command\","
|
||||
" \"arguments\": {"
|
||||
" \"command-line\": \"drive_del drive0\""
|
||||
response = qmp("{'execute': 'human-monitor-command',"
|
||||
" 'arguments': {"
|
||||
" 'command-line': 'drive_del drive0'"
|
||||
"}}");
|
||||
g_assert(response);
|
||||
response_return = qdict_get_try_str(response, "return");
|
||||
@ -36,9 +36,9 @@ static void test_drive_without_dev(void)
|
||||
/* Ensure re-adding the drive works - there should be no duplicate ID error
|
||||
* because the old drive must be gone.
|
||||
*/
|
||||
response = qmp("{\"execute\": \"human-monitor-command\","
|
||||
" \"arguments\": {"
|
||||
" \"command-line\": \"drive_add 0 if=none,id=drive0\""
|
||||
response = qmp("{'execute': 'human-monitor-command',"
|
||||
" 'arguments': {"
|
||||
" 'command-line': 'drive_add 0 if=none,id=drive0'"
|
||||
"}}");
|
||||
g_assert(response);
|
||||
response_return = qdict_get_try_str(response, "return");
|
||||
@ -59,10 +59,10 @@ static void test_after_failed_device_add(void)
|
||||
/* Make device_add fail. If this leaks the virtio-blk-pci device then a
|
||||
* reference to drive0 will also be held (via qdev properties).
|
||||
*/
|
||||
response = qmp("{\"execute\": \"device_add\","
|
||||
" \"arguments\": {"
|
||||
" \"driver\": \"virtio-blk-pci\","
|
||||
" \"drive\": \"drive0\""
|
||||
response = qmp("{'execute': 'device_add',"
|
||||
" 'arguments': {"
|
||||
" 'driver': 'virtio-blk-pci',"
|
||||
" 'drive': 'drive0'"
|
||||
"}}");
|
||||
g_assert(response);
|
||||
error = qdict_get_qdict(response, "error");
|
||||
@ -70,9 +70,9 @@ static void test_after_failed_device_add(void)
|
||||
QDECREF(response);
|
||||
|
||||
/* Delete the drive */
|
||||
response = qmp("{\"execute\": \"human-monitor-command\","
|
||||
" \"arguments\": {"
|
||||
" \"command-line\": \"drive_del drive0\""
|
||||
response = qmp("{'execute': 'human-monitor-command',"
|
||||
" 'arguments': {"
|
||||
" 'command-line': 'drive_del drive0'"
|
||||
"}}");
|
||||
g_assert(response);
|
||||
g_assert_cmpstr(qdict_get_try_str(response, "return"), ==, "");
|
||||
@ -81,9 +81,9 @@ static void test_after_failed_device_add(void)
|
||||
/* Try to re-add the drive. This fails with duplicate IDs if a leaked
|
||||
* virtio-blk-pci exists that holds a reference to the old drive0.
|
||||
*/
|
||||
response = qmp("{\"execute\": \"human-monitor-command\","
|
||||
" \"arguments\": {"
|
||||
" \"command-line\": \"drive_add pci-addr=auto if=none,id=drive0\""
|
||||
response = qmp("{'execute': 'human-monitor-command',"
|
||||
" 'arguments': {"
|
||||
" 'command-line': 'drive_add pci-addr=auto if=none,id=drive0'"
|
||||
"}}");
|
||||
g_assert(response);
|
||||
g_assert_cmpstr(qdict_get_try_str(response, "return"), ==, "OK\r\n");
|
||||
|
Loading…
Reference in New Issue
Block a user