mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qapi replay: Elide redundant has_FOO in generated C

Browse Source 
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with.  Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step.  This is the step for qapi/replay.json.

Said commit explains the transformation in more detail.  The invariant
violations mentioned there do not occur here.

Cc: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20221104160712.3005652-22-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2022-11-04 17:07:03 +01:00
parent 047f2ca1ce
commit d01c00463f
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
replay/replay-debugging.c
View File

@ -50,7 +50,6 @@ ReplayInfo *qmp_query_replay(Error **errp)
retval->mode = replay_mode; retval->mode = replay_mode;
if (replay_get_filename()) { if (replay_get_filename()) {
retval->filename = g_strdup(replay_get_filename()); retval->filename = g_strdup(replay_get_filename());
retval->has_filename = true;
} }
retval->icount = replay_get_current_icount(); retval->icount = replay_get_current_icount();
return retval; return retval;

1
scripts/qapi/schema.py
View File

@ -759,7 +759,6 @@ class QAPISchemaObjectTypeMember(QAPISchemaMember):
assert self.type assert self.type
# Temporary hack to support dropping the has_FOO in reviewable chunks # Temporary hack to support dropping the has_FOO in reviewable chunks
opt_out = [ opt_out = [
'qapi/replay.json',
'qapi/rocker.json', 'qapi/rocker.json',
'qapi/run-state.json', 'qapi/run-state.json',
'qapi/stats.json', 'qapi/stats.json',