mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpus-common: remove redundant call to exclusive_idle()

Browse Source 
No need to call exclusive_idle() from cpu_exec_end since it is done
immediately afterwards in cpu_exec_start.  Any exclusive section could
run as soon as cpu_exec_end leaves, because cpu->running is false and the
mutex is not taken, so the call does not add any protection either.

Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2016-09-02 21:02:10 +02:00
parent c978b31687
commit cf07da65f3
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cpus-common.c
View File

@ -221,7 +221,6 @@ void cpu_exec_end(CPUState *cpu)
qemu_cond_signal(&exclusive_cond);
}
}
exclusive_idle();
qemu_mutex_unlock(&qemu_cpu_list_lock);
}

1
docs/tcg-exclusive.promela
View File

@ -124,7 +124,6 @@ byte has_waiter[N_CPUS];
} \
:: else -> skip; \
fi; \
exclusive_idle(); \
MUTEX_UNLOCK(mutex);
// Promela processes