mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

memory: Move FlatView allocation to a helper

Browse Source 
This moves a FlatView allocation and initialization to a helper.
While we are nere, replace g_new with g_new0 to not to bother if we add
new fields in the future.

This should cause no behavioural change.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-Id: <20170921085110.25598-4-aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Alexey Kardashevskiy 2017-09-21 18:50:55 +10:00 committed by Paolo Bonzini
parent 9a62e24f45
commit cc94cd6d36
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
memory.c
View File

@ -258,12 +258,14 @@ static bool flatrange_equal(FlatRange *a, FlatRange *b)
&& a->readonly == b->readonly; && a->readonly == b->readonly;
} }
static void flatview_init(FlatView *view) static FlatView *flatview_new(void)
{ {
FlatView *view;
view = g_new0(FlatView, 1);
view->ref = 1; view->ref = 1;
view->ranges = NULL;
view->nr = 0; return view;
view->nr_allocated = 0;
} }
/* Insert a range into a given position. Caller is responsible for maintaining /* Insert a range into a given position. Caller is responsible for maintaining
@ -707,8 +709,7 @@ static FlatView *generate_memory_topology(MemoryRegion *mr)
{ {
FlatView *view; FlatView *view;
view = g_new(FlatView, 1); view = flatview_new();
flatview_init(view);
if (mr) { if (mr) {
render_memory_region(view, mr, int128_zero(), render_memory_region(view, mr, int128_zero(),
@ -2629,8 +2630,7 @@ void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name)
as->ref_count = 1; as->ref_count = 1;
as->root = root; as->root = root;
as->malloced = false; as->malloced = false;
as->current_map = g_new(FlatView, 1); as->current_map = flatview_new();
flatview_init(as->current_map);
as->ioeventfd_nb = 0; as->ioeventfd_nb = 0;
as->ioeventfds = NULL; as->ioeventfds = NULL;
QTAILQ_INIT(&as->listeners); QTAILQ_INIT(&as->listeners);