mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pci: Use bus master address space for delivering MSI/MSI-X messages

Browse Source 
The spec says (and real HW confirms this) that, if the bus master bit
is 0, the device will not generate any PCI accesses. MSI and MSI-X
messages fall among these, so we should use the corresponding address
space to deliver them. This will prevent delivery if bus master support
is disabled.

Cc: qemu-stable@nongnu.org
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Jan Kiszka 2014-07-27 09:08:29 +02:00 committed by Michael S. Tsirkin
parent 2d591ce2ae
commit cc943c36fa
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/pci/msi.c
View File

@ -291,7 +291,7 @@ void msi_notify(PCIDevice *dev, unsigned int vector)
"notify vector 0x%x" "notify vector 0x%x"
" address: 0x%"PRIx64" data: 0x%"PRIx32"\n", " address: 0x%"PRIx64" data: 0x%"PRIx32"\n",
vector, msg.address, msg.data); vector, msg.address, msg.data);
stl_le_phys(&address_space_memory, msg.address, msg.data); stl_le_phys(&dev->bus_master_as, msg.address, msg.data);
} }
/* Normally called by pci_default_write_config(). */ /* Normally called by pci_default_write_config(). */

2
hw/pci/msix.c
View File

@ -439,7 +439,7 @@ void msix_notify(PCIDevice *dev, unsigned vector)
msg = msix_get_message(dev, vector); msg = msix_get_message(dev, vector);
stl_le_phys(&address_space_memory, msg.address, msg.data); stl_le_phys(&dev->bus_master_as, msg.address, msg.data);
} }
void msix_reset(PCIDevice *dev) void msix_reset(PCIDevice *dev)