mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

virtio-net: broken RX filtering logic fixed

Browse Source 
Upon processing of VIRTIO_NET_CTRL_MAC_TABLE_SET command
multicast list overwrites unicast list in mac_table.
This leads to broken logic for both unicast and multicast RX filtering.

Signed-off-by: Dmitry Fleytman <dfleytma@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Dmitry Fleytman 2013-09-22 18:09:13 +03:00 committed by Stefan Hajnoczi
parent 1597591cca
commit cc386e9672
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/net/virtio-net.c
View File

@ -657,7 +657,8 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t cmd,
} }
if (n->mac_table.in_use + mac_data.entries <= MAC_TABLE_ENTRIES) { if (n->mac_table.in_use + mac_data.entries <= MAC_TABLE_ENTRIES) {
s = iov_to_buf(iov, iov_cnt, 0, n->mac_table.macs, s = iov_to_buf(iov, iov_cnt, 0,
&n->mac_table.macs[n->mac_table.in_use * ETH_ALEN],
mac_data.entries * ETH_ALEN); mac_data.entries * ETH_ALEN);
if (s != mac_data.entries * ETH_ALEN) { if (s != mac_data.entries * ETH_ALEN) {
goto error; goto error;