mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/guest-random: Clean up global variable shadowing

Browse Source 
Fix:

  util/guest-random.c:90:45: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
  int qemu_guest_random_seed_main(const char *optarg, Error **errp)
                                              ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14: note: previous declaration is here
  extern char *optarg;                    /* getopt(3) external variables */
               ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20231004120019.93101-13-philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
Philippe Mathieu-Daudé 2023-10-04 14:00:15 +02:00 committed by Markus Armbruster
parent 5bebe03f51
commit ca84e7b225
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/qemu/guest-random.h
View File

@ -13,16 +13,16 @@
#define QEMU_GUEST_RANDOM_H #define QEMU_GUEST_RANDOM_H
/** /**
* qemu_guest_random_seed_main(const char *optarg, Error **errp) * qemu_guest_random_seed_main(const char *seedstr, Error **errp)
* @optarg: a non-NULL pointer to a C string * @seedstr: a non-NULL pointer to a C string
* @errp: an error indicator * @errp: an error indicator
* *
* The @optarg value is that which accompanies the -seed argument. * The @seedstr value is that which accompanies the -seed argument.
* This forces qemu_guest_getrandom into deterministic mode. * This forces qemu_guest_getrandom into deterministic mode.
* *
* Returns 0 on success, < 0 on failure while setting *errp. * Returns 0 on success, < 0 on failure while setting *errp.
*/ */
int qemu_guest_random_seed_main(const char *optarg, Error **errp); int qemu_guest_random_seed_main(const char *seedstr, Error **errp);
/** /**
* qemu_guest_random_seed_thread_part1(void) * qemu_guest_random_seed_thread_part1(void)

6
util/guest-random.c
View File

@ -87,11 +87,11 @@ void qemu_guest_random_seed_thread_part2(uint64_t seed)
} }
} }
int qemu_guest_random_seed_main(const char *optarg, Error **errp) int qemu_guest_random_seed_main(const char *seedstr, Error **errp)
{ {
uint64_t seed; uint64_t seed;
if (parse_uint_full(optarg, 0, &seed)) { if (parse_uint_full(seedstr, 0, &seed)) {
error_setg(errp, "Invalid seed number: %s", optarg); error_setg(errp, "Invalid seed number: %s", seedstr);
return -1; return -1;
} else { } else {
deterministic = true; deterministic = true;