mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

s390x/zpci: drop msix.available

Browse Source 
I fail to see why this is useful as we require MSIX always and
completely fail adding a device.

Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20181105110313.29312-2-david@redhat.com>
Fixes: 4f6482bfe3
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
This commit is contained in:
David Hildenbrand 2018-11-05 12:03:10 +01:00 committed by Cornelia Huck
parent bb9bf94b3e
commit c8a7cafa4b
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/s390x/s390-pci-bus.c
View File

@ -745,7 +745,6 @@ static int s390_pci_msix_init(S390PCIBusDevice *pbdev)
pos = pci_find_capability(pbdev->pdev, PCI_CAP_ID_MSIX); pos = pci_find_capability(pbdev->pdev, PCI_CAP_ID_MSIX);
if (!pos) { if (!pos) {
pbdev->msix.available = false;
return -1; return -1;
} }
@ -761,7 +760,6 @@ static int s390_pci_msix_init(S390PCIBusDevice *pbdev)
pbdev->msix.pba_bar = pba & PCI_MSIX_FLAGS_BIRMASK; pbdev->msix.pba_bar = pba & PCI_MSIX_FLAGS_BIRMASK;
pbdev->msix.pba_offset = pba & ~PCI_MSIX_FLAGS_BIRMASK; pbdev->msix.pba_offset = pba & ~PCI_MSIX_FLAGS_BIRMASK;
pbdev->msix.entries = (ctrl & PCI_MSIX_FLAGS_QSIZE) + 1; pbdev->msix.entries = (ctrl & PCI_MSIX_FLAGS_QSIZE) + 1;
pbdev->msix.available = true;
name = g_strdup_printf("msix-s390-%04x", pbdev->uid); name = g_strdup_printf("msix-s390-%04x", pbdev->uid);
memory_region_init_io(&pbdev->msix_notify_mr, OBJECT(pbdev), memory_region_init_io(&pbdev->msix_notify_mr, OBJECT(pbdev),

1
hw/s390x/s390-pci-bus.h
View File

@ -252,7 +252,6 @@ typedef struct ChscSeiNt2Res {
} QEMU_PACKED ChscSeiNt2Res; } QEMU_PACKED ChscSeiNt2Res;
typedef struct S390MsixInfo { typedef struct S390MsixInfo {
bool available;
uint8_t table_bar; uint8_t table_bar;
uint8_t pba_bar; uint8_t pba_bar;
uint16_t entries; uint16_t entries;