mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix checksum writing in signboot.sh

Browse Source 
The printf command takes an octal value after \, so we have to convert
our decimal representation to octal first and then write it.

This unbreaks extboot signing. Multiboot wasn't affected yet because
the checksum was < 8.

Spotted and first patch by Glauber Costa <glommer@redhat.com>.
Printf idea by Paolo Bonzini <bonzini@gnu.org>.

Signed-off-by: Alexander Graf <agraf@suse.de>
CC: Glauber Costa <glommer@redhat.com>
CC: Paolo Bonzini <bonzini@gnu.org>
CC: Jan Ondrej <ondrejj@salstar.sk>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Message-Id:
This commit is contained in:
Alexander Graf 2009-08-01 11:48:31 +02:00 committed by Anthony Liguori
parent 9aebd98aab
commit c66b57fc14
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pc-bios/optionrom/signrom.sh
View File

@ -39,7 +39,8 @@ done
sum=$(( $sum % 256 )) sum=$(( $sum % 256 ))
sum=$(( 256 - $sum )) sum=$(( 256 - $sum ))
sum_octal=$( printf "%o" $sum )
# and write the output file # and write the output file
cp "$1" "$2" cp "$1" "$2"
printf "\\$sum" | dd of="$2" bs=1 count=1 seek=$size conv=notrunc 2>/dev/null printf "\\$sum_octal" | dd of="$2" bs=1 count=1 seek=$size conv=notrunc 2>/dev/null